check for cJSON_True

Steve Bendiola · Steve Bendiola · commit 2421e1094752 · 2017-11-20T12:57:18.000-06:00
diff --git a/src/IndexParser.cpp b/src/IndexParser.cpp
@@ -78,7 +78,7 @@ void IndexParser::parseIndex(cJSON *index, Index::Builder *builder,
 
 bool IndexParser::getBoolean(cJSON *index, const char *field) const {
     return cJSON_GetObjectItem(index, field)
-           && strcmp("true", cJSON_GetObjectItem(index, field)->string);
+           && cJSON_GetObjectItem(index, field)->type == cJSON_True;
 }
 
 std::string IndexParser::getOrThrowStr(cJSON *index, const char *field) const {

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ void IndexParser::parseIndex(cJSON index, Index::Builder builder,`
`78`	`78`
`79`	`79`	`bool IndexParser::getBoolean(cJSON index, const char field) const {`
`80`	`80`	`return cJSON_GetObjectItem(index, field)`
`81`		`- && strcmp("true", cJSON_GetObjectItem(index, field)->string);`
	`81`	`+ && cJSON_GetObjectItem(index, field)->type == cJSON_True;`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`std::string IndexParser::getOrThrowStr(cJSON index, const char field) const {`