Some clang-tidy suggested fixes for C++11

Author: mattgodbolt

src/Index.cpp

@@ -120,7 +120,7 @@ struct IndexHandler : IndexSink {
     IndexHandler(Log &log, std::unique_ptr<LineIndexer> indexer) :
             log(log), indexer(std::move(indexer)), currentLine(0) {}
 
-    virtual ~IndexHandler() {}
+    ~IndexHandler() override = default;
 
     bool onLine(uint64_t lineNumber, const char *line, size_t length) {
         try {

src/IndexSink.h

@@ -8,7 +8,7 @@
 // to the IndexSink's add method.
 class IndexSink {
 public:
-    virtual ~IndexSink() { }
+    virtual ~IndexSink() = default;
 
     // Add a key to be indexed. offset should be the offset within the line.
     virtual void add(StringView item, size_t offset) = 0;

src/LineIndexer.h

@@ -10,7 +10,7 @@ class IndexSink;
 // matches within it (based on whatever it indexes, e.g. a matching RegExp).
 class LineIndexer {
 public:
-    virtual ~LineIndexer() { }
+    virtual ~LineIndexer() = default;
 
     virtual void index(IndexSink &sink, StringView line) = 0;
-};
+};

src/LineSink.h

@@ -5,7 +5,7 @@
 // A sink to be called with each line in a file.
 class LineSink {
 public:
-    virtual ~LineSink() { }
+    virtual ~LineSink() = default;
 
     virtual bool onLine(
             size_t lineNumber,

src/Log.h

@@ -7,7 +7,7 @@
 // CaptureLog.
 class Log {
 public:
-    virtual ~Log() { }
+    virtual ~Log() = default;
 
     enum class Severity {
         Debug, Info, Warning, Error

src/RangeFetcher.h

@@ -16,7 +16,7 @@ class RangeFetcher {
     // A handler for line ranges.
     class Handler {
     public:
-        virtual ~Handler() { }
+        virtual ~Handler() = default;
 
         // Called for each line within a group.
         virtual void onLine(uint64_t line) = 0;

src/zq.cpp

@@ -7,6 +7,7 @@
 
 #include <iostream>
 #include <stdexcept>
+#include <utility>
 #include "RangeFetcher.h"
 
 using namespace std;
@@ -17,7 +18,7 @@ namespace {
 struct PrintSink : LineSink {
     bool printLineNum;
 
-    PrintSink(bool printLineNum) : printLineNum(printLineNum) { }
+    explicit PrintSink(bool printLineNum) : printLineNum(printLineNum) { }
 
     bool onLine(size_t l, size_t, const char *line, size_t length) override {
         if (printLineNum) cout << l << ":";
@@ -33,14 +34,15 @@ struct PrintHandler : RangeFetcher::Handler {
     const std::string sep;
 
     PrintHandler(Index &index, LineSink &sink, bool printSep,
-                 const std::string &sep)
-            : index(index), sink(sink), printSep(printSep), sep(sep) { }
+                 std::string sep)
+            : index(index), sink(sink), printSep(printSep),
+              sep(std::move(sep)) { }
 
-    virtual void onLine(uint64_t line) override {
+    void onLine(uint64_t line) override {
         index.getLine(line, sink);
     }
 
-    virtual void onSeparator() override {
+    void onSeparator() override {
         if (printSep)
             cout << sep << endl;
     }