add uri support

Author: Steve Bendiola

src/Index.cpp

@@ -471,7 +471,8 @@ struct Index::Builder::Impl : LineSink {
               addIndexSql(log), addMetaSql(log), saveAllLines_{false} {}
 
     void init() {
-        if (unlink(indexFilename.c_str()) == 0) {
+        auto file = db.toFile(indexFilename);
+        if (unlink(file.c_str()) == 0) {
             log.warn("Rebuilding existing index ", indexFilename);
         }
         db.open(indexFilename, false);

src/Sqlite.cpp

@@ -5,6 +5,7 @@
 #include "SqliteError.h"
 #include <cstring>
 #include "Log.h"
+#include "RegExp.h"
 
 Sqlite::Sqlite(Log &log)
         : log_(&log), sql_(nullptr) {
@@ -20,7 +21,7 @@ void Sqlite::open(const std::string &filename, bool readOnly) {
                readOnly ? "read-only" : "read-write", " mode");
     R(sqlite3_open_v2(filename.c_str(), &sql_,
                       readOnly ? SQLITE_OPEN_READONLY :
-                      SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE, nullptr));
+                      SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE | SQLITE_OPEN_URI, nullptr));
     R(sqlite3_extended_result_codes(sql_, true));
 }
 
@@ -144,3 +145,28 @@ void Sqlite::Statement::R(int result) const {
     if (result != SQLITE_OK)
         throw SqliteError(sqlite3_errmsg(sqlite3_db_handle(statement_)));
 }
+
+std::string Sqlite::toFile(const std::string &uri) {
+    RegExp uriRegex("^(([^:/?#]+):)?(//([^/?#]*))?([^?#]*)");
+    RegExp::Matches matches;
+    if (!uriRegex.exec(uri, matches)) {
+        return uri;
+    }
+    auto protocol = matches[1];
+    auto result = std::string(uri.c_str() + protocol.first, protocol.second - protocol.first);
+    if (result.find("file:") != 0) {
+        throw std::runtime_error(
+                "no uri support for '" + result+ "'");
+    }
+    auto start = protocol.second;
+    if (matches.size() > 3) {
+        auto slashes = matches[3];
+        start =  (slashes.second != 0) ? slashes.second : slashes.first;
+    }
+    auto path = std::string(uri.c_str() + start);
+    auto paramsStart = path.rfind("?");
+    if (paramsStart != std::string::npos) {
+        path.resize(paramsStart);
+    }
+    return path;
+}

src/Sqlite.h

@@ -36,6 +36,7 @@ class Sqlite {
 
     void open(const std::string &filename, bool readOnly);
     void close();
+    std::string toFile(const std::string &uri);
 
     class Statement {
         Log *log_;

tests/IndexTest.cpp

@@ -328,6 +328,8 @@ TEST_CASE("sparsely indexes files", "[Index]") {
     }
 }
 
+
+
 TEST_CASE("metadata tests", "[Index]") {
     TempDir tempDir;
     CaptureLog log;

tests/SqliteTest.cpp

@@ -115,3 +115,80 @@ TEST_CASE("handles binds and blobs", "[Sqlite]") {
     for (int i = 0; i < byteLen; ++i) REQUIRE(blob2[i] == (0xff ^ (i & 0xff)));
     CHECK(select.step() == true);
 }
+
+
+TEST_CASE("handles binds and blobs uri", "[Sqlite]") {
+    TempDir tempDir;
+    CaptureLog log;
+    Sqlite sqlite(log);
+    auto dbPath = "file:" +tempDir.path + "/db.sqlite?foo=bar";
+    sqlite.open(dbPath, false);
+
+    REQUIRE(sqlite.prepare("create table t(offset integer, data blob)").step() == true);
+    auto inserter = sqlite.prepare("insert into t values(:id, :data)");
+    inserter.bindInt64(":id", 1234);
+    constexpr auto byteLen = 1024;
+    char bytes[byteLen];
+    for (int i = 0; i < byteLen; ++i) bytes[i] = i & 0xff;
+    inserter.bindBlob(":data", bytes, byteLen);
+    CHECK(inserter.step() == true);
+    inserter.reset();
+    inserter.bindInt64(":id", 5678);
+    for (int i = 0; i < byteLen; ++i) bytes[i] = (i & 0xff) ^ 0xff;
+    inserter.bindBlob(":data", bytes, byteLen);
+    CHECK(inserter.step() == true);
+
+    auto select = sqlite.prepare("select * from t order by offset");
+    CHECK(select.columnCount() == 2);
+    CHECK(select.step() == false);
+    CHECK(select.columnName(0) == "offset");
+    CHECK(select.columnName(1) == "data");
+    CHECK(select.columnInt64(0) == 1234);
+    auto blob1 = select.columnBlob(1);
+    REQUIRE(blob1.size() == byteLen);
+    for (int i = 0; i < byteLen; ++i) REQUIRE(blob1[i] == (i & 0xff));
+    CHECK(select.step() == false);
+    CHECK(select.columnInt64(0) == 5678);
+    auto blob2 = select.columnBlob(1);
+    REQUIRE(blob2.size() == byteLen);
+    for (int i = 0; i < byteLen; ++i) REQUIRE(blob2[i] == (0xff ^ (i & 0xff)));
+    CHECK(select.step() == true);
+}
+
+TEST_CASE("uri convert to file", "[Sqlite]") {
+    TempDir tempDir;
+    CaptureLog log;
+    Sqlite sqlite(log);
+
+    //    file:data.db	Open the file "data.db" in the current directory.
+    REQUIRE(sqlite.toFile("file:data.db") == "data.db");
+
+    //    file:/home/fred/data.db
+    //    file:///home/fred/data.db
+    //    file://localhost/home/fred/data.db Open the database file "/home/fred/data.db".
+    REQUIRE(sqlite.toFile("file:/home/fred/data.db") == "/home/fred/data.db");
+    REQUIRE(sqlite.toFile("file:///home/fred/data.db") == "/home/fred/data.db");
+    REQUIRE(sqlite.toFile("file://localhost/home/fred/data.db") == "/home/fred/data.db");
+    //
+    //
+    //    file://darkstar/home/fred/data.db	An error. "darkstar" is not a recognized authority.
+    //let sqlite handle
+    REQUIRE(sqlite.toFile("file://darkstar/home/fred/data.db") == "/home/fred/data.db");
+    //
+    //    file:///C:/Documents%20and%20Settings/fred/Desktop/data.db	Windows only: Open the file "data.db" on fred's desktop on drive C:. Note that the %20 escaping in this example is not strictly necessary - space characters can be used literally in URI filenames.
+    //REQUIRE(sqlite.toFile("file:///C:/Documents%20and%20Settings/fred/Desktop/data.db") == "/home/fred/data.db");
+    //
+    //    file:data.db?mode=ro&cache=private	Open file "data.db" in the current directory for read-only access. Regardless of whether or not shared-cache mode is enabled by default, use a private cache.
+    REQUIRE(sqlite.toFile("file:data.db?mode=ro&cache=private") == "data.db");
+
+    REQUIRE(sqlite.toFile("file:/home/fred/foo/bar/data.db?mode=ro&cache=private") == "/home/fred/foo/bar/data.db");
+    //
+    //    file:/home/fred/data.db?vfs=unix-dotfile	Open file "/home/fred/data.db". Use the special VFS "unix-dotfile" that uses dot-files in place of posix advisory locking.
+    REQUIRE(sqlite.toFile("file:/home/fred/data.db?vfs=unix-dotfile") == "/home/fred/data.db");
+    //    file:data.db?mode=readonly	An error. "readonly" is not a valid option for the "mode" parameter. Use "ro" instead: "file:data.db?mode=ro".
+    REQUIRE(sqlite.toFile("file:data.db?mode=readonly") == "data.db");
+
+
+    REQUIRE_THROWS(sqlite.toFile("http://data.db?mode=readonly"));
+
+}