Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last will and testament missing #21

Open
ThomDietrich opened this issue May 16, 2021 · 8 comments · May be fixed by #35
Open

Last will and testament missing #21

ThomDietrich opened this issue May 16, 2021 · 8 comments · May be fixed by #35

Comments

@ThomDietrich
Copy link

Hello,
this addon does not seem to implement the concept of MQTT "last will and testament". Is there any specific reason for it? I would otherwise be interested to provide a PR for it.

All the best! th

For reference:

@ThomDietrich
Copy link
Author

@matthewwall is this project still active? Are you ready to accept PRs?

@matthewwall
Copy link
Owner

working on some other weewx things at the moment, but should get back to the mqtt extension soon...

@ThomDietrich
Copy link
Author

Hey @matthewwall, would you accept a PR if provided?

@ThomDietrich
Copy link
Author

My weather station went offline two days ago and I didn't realize because of this. Would you merge a PR?

@roe-dl
Copy link

roe-dl commented Sep 9, 2022

It seems very difficult to get Matthew Wall's attention. I sent a PR in April, and I got no answer so far.

@ThomDietrich
Copy link
Author

He is understandable busy with other things atm. I had times like this in my OSS life as well.

@matthewwall may I suggest again to move your projects to an organization and to add more contributors to it? There are other projects (like neowx) which would also fit nicely in this organization and the weewx community would benefit from this heavily.

As discussed in matthewwall/weewx-interceptor#97 (comment)

@matthewwall
Copy link
Owner

@ThomDietrich i am happy to merge a PR for lwat. i do not see it among the current outstanding PRs. am i missing it somehow?

@ThomDietrich
Copy link
Author

Nope didn't want to invest the time, unsure of whether it would be merged. I will work on one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants