Define the required CLI version once, in a central place

Author: matthiask

app/settings.py

@@ -209,3 +209,5 @@
 FORM_RENDERER = "form_rendering.FormRendering"
 
 DEEPL_AUTH_KEY = env("DEEPL_AUTH_KEY")
+
+CLI_VERSION = "0.0.3"

projects/test_views.py

@@ -1,5 +1,6 @@
 from unittest.mock import Mock, patch
 
+from django.conf import settings
 from django.test import Client, TestCase
 from django.test.utils import override_settings
 
@@ -87,32 +88,33 @@ def test_smoke(self):
 
         # API test
         r = su_client.get(
-            "/api/pofile/test/fr/djangojs/", headers={"x-cli-version": "0.0.3"}
+            "/api/pofile/test/fr/djangojs/",
+            headers={"x-cli-version": settings.CLI_VERSION},
         )
         self.assertEqual(r.status_code, 403)
 
         r = su_client.get(
             "/api/pofile/test/fr/djangojs/",
-            headers={"x-token": superuser.token, "x-cli-version": "0.0.3"},
+            headers={"x-token": superuser.token, "x-cli-version": settings.CLI_VERSION},
         )
         self.assertEqual(r.status_code, 200)
         self.assertEqual(r.content.decode("utf-8"), c.pofile)
 
         r = su_client.patch(
             "/api/pofile/test/fr/djangojs/",
-            headers={"x-token": superuser.token, "x-cli-version": "0.0.3"},
+            headers={"x-token": superuser.token, "x-cli-version": settings.CLI_VERSION},
         )
         self.assertEqual(r.status_code, 405)
 
         r = su_client.get(
             "/api/pofile/test/de/djangojs/",
-            headers={"x-token": superuser.token, "x-cli-version": "0.0.3"},
+            headers={"x-token": superuser.token, "x-cli-version": settings.CLI_VERSION},
         )
         self.assertEqual(r.status_code, 404)
 
         r = su_client.post(
             "/api/pofile/test/fr/djangojs/",
-            headers={"x-token": superuser.token, "x-cli-version": "0.0.3"},
+            headers={"x-token": superuser.token, "x-cli-version": settings.CLI_VERSION},
             data=b"""\
 #: conf/strings.js frontend/intro/intro.js frontend/people/person.js
 msgid "Continue"
@@ -149,7 +151,7 @@ def test_smoke(self):
         # Different language!
         r = su_client.put(
             "/api/pofile/test/de/djangojs/",
-            headers={"x-token": superuser.token, "x-cli-version": "0.0.3"},
+            headers={"x-token": superuser.token, "x-cli-version": settings.CLI_VERSION},
             data=b"""\
 #: conf/strings.js frontend/intro/intro.js frontend/people/person.js
 msgid "Continue"

projects/views.py

@@ -132,7 +132,9 @@ def suggest(request):
 
 @csrf_exempt
 def pofile(request, project, language_code, domain):
-    if not (version := request.headers.get("x-cli-version")) or (version != "0.0.3"):
+    if not (version := request.headers.get("x-cli-version")) or (
+        version != settings.CLI_VERSION
+    ):
         return http.HttpResponseBadRequest(f"Incorrect CLI version {version!r}")
 
     user = User.objects.filter(token=request.headers.get("x-token")).first()