Only non-staff users should be assigned explicitly

matthiask · matthiask · commit e1cf5ccb61fd · 2024-07-05T10:14:06.000+02:00
diff --git a/projects/migrations/0001_initial.py b/projects/migrations/0001_initial.py
@@ -35,6 +35,8 @@ class Migration(migrations.Migration):
                 (
                     "users",
                     models.ManyToManyField(
+                        blank=True,
+                        limit_choices_to={"is_staff": False},
                         related_name="projects",
                         to=settings.AUTH_USER_MODEL,
                         verbose_name="users",
diff --git a/projects/models.py b/projects/models.py
@@ -36,6 +36,8 @@ class Project(models.Model):
         settings.AUTH_USER_MODEL,
         related_name="projects",
         verbose_name=_("users"),
+        blank=True,  # Only internal is fine.
+        limit_choices_to={"is_staff": False},
     )
     token = models.CharField(_("token"), max_length=100, editable=False, unique=True)
 

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,8 @@ class Migration(migrations.Migration):`
`35`	`35`	`(`
`36`	`36`	`"users",`
`37`	`37`	`models.ManyToManyField(`
	`38`	`+ blank=True,`
	`39`	`+ limit_choices_to={"is_staff": False},`
`38`	`40`	`related_name="projects",`
`39`	`41`	`to=settings.AUTH_USER_MODEL,`
`40`	`42`	`verbose_name="users",`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,8 @@ class Project(models.Model):`
`36`	`36`	`settings.AUTH_USER_MODEL,`
`37`	`37`	`related_name="projects",`
`38`	`38`	`verbose_name=_("users"),`
	`39`	`+ blank=True, # Only internal is fine.`
	`40`	`+ limit_choices_to={"is_staff": False},`
`39`	`41`	`)`
`40`	`42`	`token = models.CharField(_("token"), max_length=100, editable=False, unique=True)`
`41`	`43`