Set up ESLint for the repo and fix lint issues #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@tyom is attempting to deploy a commit to the Skill Recordings Team on Vercel. A member of the Team first needs to authorize it. |
mattpocock
force-pushed
the
v1
branch
4 times, most recently
from
a5f098c to
8c4667c
Compare
mattpocock
force-pushed
the
v1
branch
2 times, most recently
from
2bb257b to
c81d9d8
Compare
This fixes the TS errors.
- Include ESLint 9 as root dependency - Set up ESLint to lint the whole repo - Extend the root config and add a few package-specific plugins for Evalite UI - Add a consistent `typecheck` npm script for type checking across the repo Use can now use `pnpm lint` in root and UI app and `pnpm typecheck` anywhere in the repo. Use `pnpm lint --fix` to attempt to fix the issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally proposed in #276. Resubmitting against v1 branch as requested.
typechecknpm script for type checking across the repoUse can now use
pnpm lintin root and UI app andpnpm typecheckanywhere in the repo.Use
pnpm lint --fixto attempt to fix the issues.Fix errors (mostly removing unused imports and variables). I left some prefixed with
_to serve as a reminder of function parameters.Also add EditorConfig file to help maintain consistent code style for those who use it.