Skip to content

Fix parse errors logged multiple times and document that debug logs can include secrets - #989

Merged
mauvilsa merged 2 commits into
mainfrom
debug-log-docs-and-dup-error
Sep 24, 2026
Merged

Fix parse errors logged multiple times and document that debug logs can include secrets#989
mauvilsa merged 2 commits into
mainfrom
debug-log-docs-and-dup-error

Conversation

@mauvilsa

@mauvilsa mauvilsa commented Sep 24, 2026

Copy link
Copy Markdown
Owner

Before submitting

  • Did you read the contributing guideline?
  • If you used a coding agent, did you fully understand and validate all generated code and ensure it follows the contributing guidelines?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • If this is a bug fix, did you verify that the tests fail without the code fix?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added bug Something isn't working documentation Improvements to the documentation labels Sep 24, 2026
github-advanced-security[bot]
github-advanced-security Bot found potential problems Sep 24, 2026
View reviewed changes
Comment thread jsonargparse/_core.py Dismissed
@codecov

codecov Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (275be48) to head (15bd5fa).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #989   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         9309      9317    +8     
=========================================
+ Hits          9309      9317    +8

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR should not merge until subcommand errors remain visible when the parent logger is changed after registration.

Findings

  1. P1 Parent error log disappears ▶

Summary

The PR marks parse errors that have already been logged so outer parse layers can avoid duplicate log entries. It also adds a regression test, documents that debug logs may expose input secrets, and updates the changelog.

Reviews (1) · Last reviewed commit: "Fix parse errors logged multiple times a..."

greptile-apps[bot]
greptile-apps Bot reviewed Sep 24, 2026
View reviewed changes
Comment thread jsonargparse/_core.py
@sonarqubecloud

sonarqubecloud Bot commented Sep 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mauvilsa
mauvilsa merged commit 1da6141 into main Sep 24, 2026
32 checks passed
@mauvilsa
mauvilsa deleted the debug-log-docs-and-dup-error branch September 24, 2026 19:03

This branch was successfully deployed

1 active deployment
sonarcloud — 15bd5fab Deployed Sep 24, 2026 by mauvilsa via sonarcloud #908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working documentation Improvements to the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mauvilsa @github-advanced-security