[BUG REPORT] Issues with latest NoMount

[UserXP-web]

Hi again...
[I hope all ok]

1. Module CI_80:
   "! Unsupported architecture: arm64"
   Module is not searching inside /bin folder for 'nm-arm64'.
   Easy to correct.

2. kernel: 5.10.236 - SUSFS: 2.1.0
   BUILD: failed at /fs/open.c

ORIGINAL patch:
#ifdef CONFIG_NOMOUNT
long nm_res;
if (nomount_handle_faccessat(dfd, filename, mode, lookup_flags, &nm_res)) {
revert_creds(old_cred);
put_cred(override_cred);
return nm_res;
}
#endif

Errors:
<> undeclared identifier 'override_cred';
<> ISO C90 forbids mixing declarations and code [-Werror,-Wdeclaration-after-statement] - PROBLEM AT long nm_res;

I CHANGE patch to:
#ifdef CONFIG_NOMOUNT
if (true) {
long nm_res;
if (nomount_handle_faccessat(dfd, filename, mode, lookup_flags, &nm_res)) {
revert_creds(old_cred);
/* put_cred(override_cred); */
return nm_res;
}
}
#endif

BUILD: ok

BOOT: ok (with problems...)

Ther device is booting. The nomount.log seems ok --- all Injects are normal

My module has these files:
/product/priv-app/SecurityCenter/SecurityCenter.apk
/product/priv-app/SecurityCenter/lib/arm64/libsec-common-utils.so
[Inside nomount.log injects both files]

The SecurityCenter.apk originally exist in path.
The libsec-common-utils.so originally NOT exist in path.

In root file-manager I can see the SecurityCenter.apk, but I can NOT see (NOT exist) /lib/arm64/libsec-common-utils.so
... so I get errors about missing library libsec-common-utils.so and the SecurityCenter.apk is not working.

Thats All
[Good work...]

[maxsteeel]

Thanks for the report. I'm aware of the problem with the module installation; I have to make changes on the module side, so that's pending as well.

Regarding the missing library, could you show me the result of this command?

su -c "/data/adb/modules/nomount/bin/nm list"

to determine if the problem is with the script, the binary, or with NoMount itself.
I'll wait for your reply, thank you so much for testing NoMount! :)

(pd. The old issue you opened is now irrelevant, as all the problems related to that issue were resolved in this refactoring. So I'll close it.)

[UserXP-web]

Output is
...
/product/priv-app/SecurityCenter/lib->/data/adb/modules/userxp.rn13garnet.patches/product/priv-app/SecurityCenter/lib
/product/priv-app/SecurityCenter/lib/arm64->/data/adb/modules/userxp.rn13garnet.patches/product/priv-app/SecurityCenter/lib/arm64
/product/priv-app/SecurityCenter/lib/arm64/libc++_shared.so->/data/adb/modules/userxp.rn13garnet.patches/product/priv-app/SecurityCenter/lib/arm64/libc++_shared.so
/product/priv-app/SecurityCenter/lib/arm64/libfastplayer.so->/data/adb/modules/userxp.rn13garnet.patches/product/priv-app/SecurityCenter/lib/arm64/libfastplayer.so
... ... ... /product/priv-app/SecurityCenter/lib/arm64/....so
/product/priv-app/SecurityCenter/SecurityCenter.apk->/data/adb/modules/userxp.rn13garnet.patches/product/priv-app/SecurityCenter/SecurityCenter.apk
/system_ext/framework/framework-ext-res/framework-ext-res.apk->/data/adb/modules/userxp.rn13garnet.patches/system_ext/framework/framework-ext-res/framework-ext-res.apk
...

Thanks for your work

...
I can't see any sub-folder inside /product/priv-app/SecurityCenter using my root file-manager.

[maxsteeel]

Please try the latest version of NoMount and let me know
(need to update both the kernel and the module; but is not necessary update the hooks)

[UserXPme]

Just test lattest version

The module is ok.

Kernel
Build problems

1. The problem with /fs/open.c and "long nm_res;" is still theere.

2. /fs/nomount.c

80:9: error: ISO C90 forbids mixing declarations and code [-Werror,-Wdeclaration-after-statement]
    u32 hash = jhash(name, len, 0); 
        ^
322:33: error: unused variable 'abs_path' [-Werror,-Wunused-variable]
    char *page_buf, *dir_path, *abs_path = NULL;
                                ^
383:11: error: unused variable 'abs_path' [-Werror,-Wunused-variable]
    char *abs_path = NULL;
          ^
628:24: error: ISO C90 forbids mixing declarations and code [-Werror,-Wdeclaration-after-statement]
                size_t len = priv_dir->dir_path_len;
                       ^
615:10: error: ISO C90 forbids mixing declarations and code [-Werror,-Wdeclaration-after-statement]
    bool is_absolute = (tmp_name->name[0] == '/');
         ^
708:20: error: ISO C90 forbids mixing declarations and code [-Werror,-Wdeclaration-after-statement]
            size_t len = priv_dir->dir_path_len;
                   ^
1298:19: error: ISO C90 forbids mixing declarations and code [-Werror,-Wdeclaration-after-statement]
            char *slash = strrchr(rule->virtual_path, '/');
                  ^
7 errors generated.

======================================

I correct the problems and build the kernel.

It's a way better.
Hide root as expected.
All detectors (I have 8), can't detect any mount and some problems I had before is now ok!!!

The PROBLEM with files that originally NOT exist
It's solved BUT...

<> The system CAN find the *.so files. SecurityCenter.apk is working ok.
<> Root file managers (MT2 and MiXplorer) NOT show the new paths/files.

Example:
/product/priv-app/SecurityCenter/SecurityCenter.apk
/product/priv-app/SecurityCenter/lib/arm64/libsec-common-utils.so
/product/priv-app/SecurityCenter/lib/arm64/libfastplayer.so

SecurityCenter/SecurityCenter.apk => visible with MT2 and MiX
SecurityCenter/lib => NOT visible in MT2 and MiX
'ls' command NOT show 'lib' folder (only show 'SecurityCenter.apk')
BUT
'cd lib' command is working and active path changed to '/product/priv-app/SecurityCenter/lib'
If I manually type the path '/product/priv-app/SecurityCenter/lib' (in MT2), I can navigate normally...???

Thats all.

==========================================
EDIT
Same issue (new files NOT shown in root file-managers) with commit 636ea9a

Build errors

nomount.c:1095:19: error: unused variable 'p_ino'

ld.lld: error: undefined symbol: nomount_should_skip
>>> referenced by namei.c:220 (fs/namei.c:220)
ld.lld: error: undefined symbol: nomount_is_traversal_allowed
>>> referenced by readdir.c:95 (fs/readdir.c:95)

I correct them using the "old" nomount.c

Module
<> At Modules page, the button has 'red letters' with 'red background'.
<> At Settings page, the checkboxes ('Detailed logging', 'Safe mode') NOT save the state.

Other that the above -> Excellent job

[maxsteeel]

Please update it in kernel and let me know how it goes please. And update your hooks (necessary in this case).

[UserXP-web]

Commit 6a395eb
Kernel build ok (no edits by me) but can not boot!!!
Do you have any tip, to take logs? ---

[What do you mean by 'update your hooks'?]
Device can not boot to recovery either (I restore from fastboot)

[maxsteeel]

@UserXP-web test the latest commit and let me know

[UserXP-web]

No, latest changes -> bootloop

Also, (I don't know if this help), no module is active.

[maxsteeel]

@UserXP-web Did you try the most recent commit? df5007c ?

btw the bootloop is during the system boot animation or is in the manufacturer's logo?

[UserXP-web]

yes, df5007c

bootloop during system boot anim