Skip to content

Commit 48262ac

Browse files
committed
remove vendored requests
1 parent ff0aa66 commit 48262ac

File tree

112 files changed

+10
-36723
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

112 files changed

+10
-36723
lines changed

.coveragerc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@ source = redminelib
44
[report]
55
show_missing = True
66
omit =
7-
*/packages/*
87
*/python?.?/*
98
*/site-packages/*

CHANGELOG.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ Changelog
1111

1212
**Changes**:
1313

14-
- *Backwards Incompatible:* Removed Python 2.6 and 3.3 support
14+
- *Backwards Incompatible:* Removed vendored Requests package and make it an external dependency as Requests did
15+
the same with it's own dependencies
16+
- *Backwards Incompatible:* Removed Python 2.6 and 3.3 support as they're not supported by Requests anymore
1517

1618
**Bugfixes**:
1719

MANIFEST.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
recursive-include tests *.py
2-
include .coveragerc README.rst CHANGELOG.rst LICENSE NOTICE redminelib/packages/requests/cacert.pem
2+
include .coveragerc README.rst CHANGELOG.rst LICENSE NOTICE

NOTICE

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,5 @@
11
Python-Redmine includes code from several Python libraries.
22

3-
Requests License
4-
================
5-
6-
Copyright 2019 Kenneth Reitz
7-
8-
Licensed under the Apache License, Version 2.0 (the "License");
9-
you may not use this file except in compliance with the License.
10-
You may obtain a copy of the License at
11-
12-
http://www.apache.org/licenses/LICENSE-2.0
13-
14-
Unless required by applicable law or agreed to in writing, software
15-
distributed under the License is distributed on an "AS IS" BASIS,
16-
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
17-
See the License for the specific language governing permissions and
18-
limitations under the License.
19-
203
Six License
214
===========
225

docs/installation.rst

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,7 @@ Dependencies
55
------------
66

77
Python-Redmine relies heavily on great `Requests <http://docs.python-requests.org>`_ library by Kenneth Reitz
8-
for all the http(s) calls. To provide better user experience, Python-Redmine vendors Requests (i.e. embeds it
9-
inside itself) and uses a so-called "smart imports" strategy to identify whether it should use the vendored
10-
version or the global one. It works like this, at the first import time Python-Redmine checks if there is a
11-
global Requests installed and if it's version is greater than the vendored Requests, Python-Redmine will use
12-
global Requests and if not, the vendored one. This strategy provides you with the following benefits:
13-
14-
* no external dependencies are installed together with Python-Redmine
15-
* no more conflicts with other libraries that depend on other version of Requests
16-
* always the latest version of Requests available at the release time of Python-Redmine
17-
* use newer versions of Requests in case of the immediate upgrade need absolutely automatically
18-
19-
.. versionadded:: 2.0.0
20-
21-
If for some reason there is a need to use a global Requests library even if it's version is lower than the
22-
bundled one, one can set a REDMINE_USE_EXTERNAL_REQUESTS environmental variable to force this behaviour.
8+
for all the http(s) calls.
239

2410
Standard Edition
2511
----------------

redminelib/engines/sync.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
Synchronous blocking engine that processes requests one by one.
33
"""
44

5+
import requests
6+
57
from . import BaseEngine
6-
from ..packages import requests
78

89

910
class SyncEngine(BaseEngine):

redminelib/packages/__init__.py

Lines changed: 0 additions & 11 deletions
This file was deleted.

redminelib/packages/requests/__init__.py

Lines changed: 0 additions & 83 deletions
This file was deleted.

redminelib/packages/requests/__version__.py

Lines changed: 0 additions & 16 deletions
This file was deleted.

redminelib/packages/requests/_internal_utils.py

Lines changed: 0 additions & 42 deletions
This file was deleted.

0 commit comments

Comments
 (0)