Skip to content

Commit 59d05e2

Browse files
committed
WIP: Bzlmod part the thirty-fourth
Added a couple more repo dependencies to targets under //test. However, `bazel test //test:all` is a bust for now, because the protoc-bridge mechanism hangs on macOS: - scalapb/protoc-bridge#366 - scalapb/protoc-bridge#367 - scalapb/protoc-bridge#379 - scalapb/protoc-bridge#380 Though scalapb/protoc-bridge#366 suggests that it only hangs occasionally, it's hanging 100% of the time for me on macOS 15.0 on a M3 Max.
1 parent 51ea4a5 commit 59d05e2

File tree

2 files changed

+6
-4
lines changed
  • test
    • src/main/scala/scalarules/test/fetch_sources

2 files changed

+6
-4
lines changed

test/BUILD

+5-4
Original file line numberDiff line numberDiff line change
@@ -610,9 +610,14 @@ scala_library(
610610
],
611611
)
612612

613+
junit_deps = [
614+
"@io_bazel_rules_scala_junit_junit" + version_suffix(SCALA_VERSION)
615+
]
616+
613617
scala_library(
614618
name = "customJunitRunner",
615619
srcs = ["src/main/scala/scalarules/test/junit/JunitCustomRunner.java"],
620+
deps = junit_deps,
616621
)
617622

618623
# make sure making a fat jar strips signatures
@@ -696,10 +701,6 @@ check_statsfile("ScalaLibBinary")
696701

697702
#discovering tests from a separate target
698703

699-
junit_deps = [
700-
"@io_bazel_rules_scala_junit_junit" + version_suffix(SCALA_VERSION)
701-
]
702-
703704
scala_library(
704705
name = "JunitSeparateTarget",
705706
srcs = ["src/main/scala/scalarules/test/junit/separate_target/JunitSeparateTargetTest.scala"],

test/src/main/scala/scalarules/test/fetch_sources/BUILD

+1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ scala_library(
44
name = "fetch_sources",
55
testonly = True,
66
srcs = ["FetchSources.scala"],
7+
deps = ["@com_google_guava_guava_21_0"],
78
)

0 commit comments

Comments
 (0)