site/worker.js: allowlist sister-podcasts.html

mcgrof · mcgrof · commit 98ebcaad98e3 · 2026-04-21T11:06:34.000-07:00
gen-podcast.py publish-site uploads sister-podcasts.html to R2
but the site worker's ALLOWED_EXACT_FILES set did not include
it, so every request 404'd even though the object was present.
Same class of bug as the earlier YYYY/MM/index.html regression.

Add sister-podcasts.html to the allowlist.

Add a regression test that walks every root-level file
publish-site uploads (index.html, sister-podcasts.html,
sponsor.html, queue.html, feed.xml, queue.xml) and asserts
isAllowedPath() returns true for each. This catches future
regressions where someone adds a new root file to the
publisher without updating the allowlist.

Generated-by: Claude AI
Signed-off-by: Luis Chamberlain &lt;mcgrof@kernel.org&gt;
diff --git a/site/worker.js b/site/worker.js
@@ -18,6 +18,7 @@ const ALLOWED_EXACT_FILES = new Set([
   'queue.html',
   'queue.xml',
   'sponsor.html',
+  'sister-podcasts.html',
   'robots.txt',
   'favicon.ico',
 ]);
diff --git a/site/worker.test.js b/site/worker.test.js
@@ -315,3 +315,38 @@ test('isAllowedPath accepts year-month archive paths', () => {
   assert.ok(!isAllowedPath('20266/04/index.html'));       // 5-digit year
   assert.ok(!isAllowedPath('2026/04/sub/index.html'));    // nested
 });
+
+
+test('sister-podcasts.html is served', async () => {
+  const env = makeEnv({
+    'sister-podcasts.html': '<html>Sister Podcasts</html>',
+  });
+  const req = makeRequest('/sister-podcasts.html');
+  const resp = await worker.fetch(req, env);
+  assert.equal(resp.status, 200);
+  const body = await resp.text();
+  assert.ok(body.includes('Sister Podcasts'));
+});
+
+
+test('all root-level HTML files uploaded by publish-site are allowlisted', () => {
+  // gen-podcast.py _publish_site uploads these four HTML files at
+  // the root. Each must be in ALLOWED_EXACT_FILES or the site worker
+  // will 404 them even after a successful publish-site run. This is
+  // the class of regression that hit us with sister-podcasts.html
+  // (which the publisher uploaded but the worker rejected).
+  const rootHtmlUploadedByPublishSite = [
+    'index.html',
+    'sister-podcasts.html',
+    'sponsor.html',
+    'queue.html',
+    'feed.xml',
+    'queue.xml',
+  ];
+  for (const name of rootHtmlUploadedByPublishSite) {
+    assert.ok(
+      isAllowedPath(name),
+      `${name} is uploaded by publish-site but not in the site worker allowlist`
+    );
+  }
+});
