Add data for anchor position container queries #28526
Conversation
github-actions
bot
added
data:css
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
First pass, LGTM overall, but a few comments.
| "deprecated": false | ||
| } | ||
| }, | ||
| "fallback": { |
There was a problem hiding this comment.
Why are we documenting this (behavioral?) subfeatures?
There was a problem hiding this comment.
This is not a behavioral subfeature. It's a named container query "feature" (in media/container queries terminology, not the BCD sense), as in @container anchored(fallback: <some-value>).
Right now there's only one feature to query against, but it's possible other container query features could exist (e.g., @container anchored(foo-bar: <some-value>) would get a foo-bar key as a peer to fallback).
There was a problem hiding this comment.
Can we add a suffix for clarity?
| "fallback": { | |
| "fallback_feature": { |
Co-authored-by: Claas Augner <[email protected]>
| "anchor_position_queries": { | ||
| "__compat": { | ||
| "description": "Anchor position queries (`anchored()`)", | ||
| "spec_url": "https://drafts.csswg.org/css-anchor-position-2/#anchored-container-queries", |
There was a problem hiding this comment.
| "anchor_position_queries": { | |
| "__compat": { | |
| "description": "Anchor position queries (`anchored()`)", | |
| "spec_url": "https://drafts.csswg.org/css-anchor-position-2/#anchored-container-queries", | |
| "anchored_function": { | |
| "__compat": { | |
| "description": "`anchored()` function", | |
| "spec_url": "https://drafts.csswg.org/css-anchor-position-2/#container-rule-anchored", |
| "deprecated": false | ||
| } | ||
| }, | ||
| "fallback": { |
There was a problem hiding this comment.
Can we add a suffix for clarity?
| "fallback": { | |
| "fallback_feature": { |
| "deprecated": false | ||
| } | ||
| }, | ||
| "any": { |
There was a problem hiding this comment.
Can we also add a suffix for clarity here?
(Unlike CSS properties, it is less obvious that this is a value.)
| "any": { | |
| "any_value": { |
| }, | ||
| "fallback": { | ||
| "__compat": { | ||
| "description": "`fallback` container feature", |
There was a problem hiding this comment.
Given that we're in the context of the @container at feature, mentioning "container" seems repetitive:
| "description": "`fallback` container feature", | |
| "description": "`fallback` feature", |
2 participants
Summary
This adds feature entries for container queries for anchor positioning.
Test results and supporting details
I tried a couple of demos on this to confirm that it's actually shipping, but https://chromestatus.com/feature/5177580990496768 is where I got the version number.
Related issues
via web-platform-dx/web-features#3403 and web-platform-dx/web-features#3564