Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web API] Support RTCInboundRtpStreamStats.trackIdentifier #24397

Closed
8 of 10 tasks
Tracked by #372
Rumyra opened this issue Feb 13, 2023 · 4 comments
Closed
8 of 10 tasks
Tracked by #372

[Web API] Support RTCInboundRtpStreamStats.trackIdentifier #24397

Rumyra opened this issue Feb 13, 2023 · 4 comments
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Feb 13, 2023

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1804676

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
  • Check if glossary updates are required for the feature you're documenting - whether an existing term needs to be updated or a new term should be added.
  • Check if BCD update means that content pages need to have experimental markup removed or deprecated markup added (front matter tags and macros).
@Rumyra Rumyra moved this from Backlog to Todo in MDN Web Docs Content Team Feb 13, 2023
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 13, 2023
@Rumyra Rumyra added Content:WebAPI Web API docs Firefox 111 and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Feb 13, 2023
@hamishwillee hamishwillee self-assigned this Feb 13, 2023
@hamishwillee
Copy link
Collaborator

hamishwillee commented Feb 14, 2023

Status

Note, the work already done is "enough for release".

Remaining work has been pushed to own-project: mdn/mdn#384

Sorry, something went wrong.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Feb 28, 2023

@Rumyra I have done the minimal work on this - there is a release note and that links to the now-supported feature RTCInboundRtpStreamStats.trackidentifier.

There is no BCD but otherwise that is kind of enough "for release".

However this has taken forever because I have tried to do the job properly and remove the RTCInboundRtpStreamStats dictionary. What actually happens is that RTCPeerConnection.getStats() returns an RTCStatsReport, and iterable object that you can loop through to get a number of different sets of named stats. The RTCInboundRtpStreamStats are just a part of one of these sets called inbound_rtp.

I have started the BCD work in mdn/browser-compat-data#18910 but we're balked by the tests not working. In discussion with Vinyl on that, but there are 100s of items in there.

Next step would be to update RTCPeerConnection.getStats() with all the possible values it can return - thats the 100s of values in that BCD above. We'd start from the spec and BCD, pull in the existing dictionaries, then hide anything for which there is no implementation yet.

Upshot, will not do for this release - simply not possible. I was thinking we might create a separate project for RTC stats I can do as a background and close this as done?

@Rumyra
Copy link
Collaborator Author

Rumyra commented Mar 14, 2023

Let's create a separate project @hamishwillee - do you want to outline it here https://github.com/mdn/mdn/issues/new?assignees=&labels=proposal%2Cneeds+triage&template=content-or-feature-suggestion.yml&title=Enter+your+proposal+here and we'll run it aside from the ff project?

@Rumyra Rumyra moved this from In Progress to Done in MDN Web Docs Content Team Mar 14, 2023
@hamishwillee
Copy link
Collaborator

@Rumyra Done - project is here: mdn/mdn#384

I've updated this issue, which is now "done".

@Rumyra Rumyra moved this from Done to Archive in MDN Web Docs Content Team May 10, 2023
@Josh-Cena Josh-Cena added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 111 labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
Archived in project
Development

No branches or pull requests

3 participants