Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: generate noteTable from only one octave #37617

Open
denes-sebestyen opened this issue Jan 12, 2025 · 1 comment
Open

Suggestion: generate noteTable from only one octave #37617

denes-sebestyen opened this issue Jan 12, 2025 · 1 comment
Labels
accepting PR Feel free to open a PR to resolve this issue Content:WebAPI Web API docs

Comments

@denes-sebestyen
Copy link
Contributor

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Simple_synth

What specific section or headline is this issue about?

Creating the note table

What information was incorrect, unhelpful, or incomplete?

I suggest to not list all the frequencies in a very long table, but have one octave listed and the others generated (doubling or halfing the frequencies). This would not only make the function shorter, but it may also teach the readers a little about music.

What did you expect to see?

I think the function could be leaner, and yet more understandable to the reader if the octaves would be generated from one short list.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

I am happy to make the changes if the page owners/editors agree with the direction I suggested

MDN metadata

Page report details
@denes-sebestyen denes-sebestyen added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 12, 2025
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 12, 2025
@Josh-Cena Josh-Cena added accepting PR Feel free to open a PR to resolve this issue and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 12, 2025
@Josh-Cena
Copy link
Member

Sure, PRs welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PR Feel free to open a PR to resolve this issue Content:WebAPI Web API docs
Projects
None yet
Development

No branches or pull requests

2 participants