- Refactoring

- code format
- adding travis-ci
- change package name
- adding request timeout

Author: meabed

.gitignore

@@ -0,0 +1,14 @@
+language: node_js
+node_js:
+  - "0.10"
+  - "0.12"
+  - "1.8"
+  - "2.5"
+  - "3.3"
+  - "4.2"
+  - "5.5"
+sudo: false
+script:
+  - "npm run-script test-travis"
+after_script:
+  - "npm install coveralls@2 && cat ./coverage/lcov.info | coveralls"

.travis.yml

@@ -1,21 +1,118 @@
-The MIT License (MIT)
-
-Copyright (c) 2016 Tajawal.com
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+Apache License
+
+Version 2.0, January 2004
+
+http://www.apache.org/licenses/
+
+TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+1. Definitions.
+
+"License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through
+9 of this document.
+
+"Licensor" shall mean the copyright owner or entity authorized by the copyright owner that is granting the License.
+
+"Legal Entity" shall mean the union of the acting entity and all other entities that control, are controlled by, or
+are under common control with that entity. For the purposes of this definition, "control" means (i) the power, direct
+or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership
+of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.
+
+"You" (or "Your") shall mean an individual or Legal Entity exercising permissions granted by this License.
+
+"Source" form shall mean the preferred form for making modifications, including but not limited to software source
+code, documentation source, and configuration files.
+
+"Object" form shall mean any form resulting from mechanical transformation or translation of a Source form, including
+but not limited to compiled object code, generated documentation, and conversions to other media types.
+
+"Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as
+indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix
+below).
+
+"Derivative Works" shall mean any work, whether in Source or Object form, that is based on (or derived from) the Work
+and for which the editorial revisions, annotations, elaborations, or other modifications represent, as a whole, an
+original work of authorship. For the purposes of this License, Derivative Works shall not include works that remain
+separable from, or merely link (or bind by name) to the interfaces of, the Work and Derivative Works thereof.
+
+"Contribution" shall mean any work of authorship, including the original version of the Work and any modifications or
+additions to that Work or Derivative Works thereof, that is intentionally submitted to Licensor for inclusion in the
+Work by the copyright owner or by an individual or Legal Entity authorized to submit on behalf of the copyright owner.
+For the purposes of this definition, "submitted" means any form of electronic, verbal, or written communication sent
+to the Licensor or its representatives, including but not limited to communication on electronic mailing lists, source
+code control systems, and issue tracking systems that are managed by, or on behalf of, the Licensor for the purpose of
+discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in
+writing by the copyright owner as "Not a Contribution."
+
+"Contributor" shall mean Licensor and any individual or Legal Entity on behalf of whom a Contribution has been
+received by Licensor and subsequently incorporated within the Work.
+
+2. Grant of Copyright License. Subject to the terms and conditions of this License, each Contributor hereby grants to
+You a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce,
+prepare Derivative Works of, publicly display, publicly perform, sublicense, and distribute the Work and such
+Derivative Works in Source or Object form.
+
+3. Grant of Patent License. Subject to the terms and conditions of this License, each Contributor hereby grants to You
+a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent
+license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license
+applies only to those patent claims licensable by such Contributor that are necessarily infringed by their Contribution
+(s) alone or by combination of their Contribution(s) with the Work to which such Contribution(s) was submitted. If You
+institute patent litigation against any entity (including a cross-claim or counterclaim in a lawsuit) alleging that
+the Work or a Contribution incorporated within the Work constitutes direct or contributory patent infringement, then
+any patent licenses granted to You under this License for that Work shall terminate as of the date such litigation is
+filed.
+
+4. Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with
+or without modifications, and in Source or Object form, provided that You meet the following conditions:
+
+You must give any other recipients of the Work or Derivative Works a copy of this License; and
+You must cause any modified files to carry prominent notices stating that You changed the files; and
+You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and
+attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the
+Derivative Works; and
+If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute
+must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices
+that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text
+file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the
+Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices
+normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License.
+You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to
+the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the
+License.
+
+You may add Your own copyright statement to Your modifications and may provide additional or different license terms
+and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a
+whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in
+this License.
+5. Submission of Contributions. Unless You explicitly state otherwise, any Contribution intentionally submitted for
+inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any
+additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any
+separate license agreement you may have executed with Licensor regarding such Contributions.
+
+6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product
+names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and
+reproducing the content of the NOTICE file.
+
+7. Disclaimer of Warranty. Unless required by applicable law or agreed to in writing, Licensor provides the Work (and
+each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT,
+MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness
+of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this
+License.
+
+8. Limitation of Liability. In no event and under no legal theory, whether in tort (including negligence), contract,
+or otherwise, unless required by applicable law (such as deliberate and grossly negligent acts) or agreed to in
+writing, shall any Contributor be liable to You for damages, including any direct, indirect, special, incidental, or
+consequential damages of any character arising as a result of this License or out of the use or inability to use the
+Work (including but not limited to damages for loss of goodwill, work stoppage, computer failure or malfunction, or
+any and all other commercial damages or losses), even if such Contributor has been advised of the possibility of such
+damages.
+
+9. Accepting Warranty or Additional Liability. While redistributing the Work or Derivative Works thereof, You may
+choose to offer, and charge a fee for, acceptance of support, warranty, indemnity, or other liability obligations
+and/or rights consistent with this License. However, in accepting such obligations, You may act only on Your own
+behalf and on Your sole responsibility, not on behalf of any other Contributor, and only if You agree to indemnify,
+defend, and hold each Contributor harmless for any liability incurred by, or claims asserted against, such Contributor
+by reason of your accepting any such warranty or additional liability.
+
+END OF TERMS AND CONDITIONS

LICENSE

@@ -2,33 +2,33 @@
 Exchange rates library for nodejs
 
 ## Motivation
-Swap is designed to be a simple and universal exchange rate library with support for multiple providers. This library is heavily inspired from [PHP Swap](https://github.com/florianv/swap)
+node-currency-swap is designed to be a simple and universal exchange rate library with support for multiple providers. This library is heavily inspired from [PHP Swap](https://github.com/florianv/swap)
 
 ## Installation
 
 ```bashp
-npm install node-swap
+npm install node-currency-swap
 ```
 ## Usage
 
 First, you need to add a provider to swap by using addProvider() method
 
 ```js
-var swap = require('node-swap');
+var swap = require('node-currency-swap');
 
-// Add the google finance provider 
+// Add the google finance provider
 swap.addProvider(new swap.providers.GoogleFinance());
 ```
 
 You can also add multiple providers
 
 ```js
-var swap = require('node-swap');
+var swap = require('node-currency-swap');
 
-// Add the google finance provider 
+// Add the google finance provider
 swap.addProvider(new swap.providers.GoogleFinance());
 
-// Add the yahoo finance provider 
+// Add the yahoo finance provider
 swap.addProvider(new swap.providers.YahooFinance());
 ```
 
@@ -65,10 +65,10 @@ __Arguments__
 swap.quote({currency: 'USD/SAR'}, function (err, rate) {
     // print the exchange rate
     console.log(rate[0].value);
-    
+
     // print the date from the provider
     console.log(rate[0].date);
-    
+
     // print the provider name
     console.log(rate[0].provider);
 });
@@ -82,10 +82,10 @@ var rate = swap.quoteSync({currency: 'USD/SAR'});
 
 // print the exchange rate
 console.log(rate[0].value);
-    
+
 // print the date from the provider
 console.log(rate[0].date);
-    
+
 // print the provider name
 console.log(rate[0].provider);
 ```
@@ -98,10 +98,10 @@ var rates = swap.quoteSync({currency: 'USD/SAR', fetchMultipleRate: true});
 rates.forEach(function(rate){
 // print the exchange rate
 console.log(rate.value);
-    
+
 // print the date from the provider
 console.log(rate.date);
-    
+
 // print the provider name
 console.log(rate.provider);
 
@@ -116,10 +116,10 @@ var rates = swap.quoteSync({currency: 'USD/SAR', cache: true});
 rates.forEach(function(rate){
 // print the exchange rate
 console.log(rate.value);
-    
+
 // print the date from the provider
 console.log(rate.date);
-    
+
 // print the provider name
 console.log(rate.provider);
 
@@ -135,7 +135,7 @@ Swap provides an object of currency codes so you can use it to avoid typos.
 ```js
 var rates = swap.quoteSync({
     currency: {
-            baseCurrency: swap.currencyCodes.ISO_USD, 
+            baseCurrency: swap.currencyCodes.ISO_USD,
             quoteCurrency: swap.currencyCodes.ISO_AED
         }
     });
@@ -188,4 +188,4 @@ swap.addProvider(new swap.providers.NationalBankOfRomania());
 
 ## Copyright and license
 
-Code released under the [MIT license](https://github.com/tajawal/swap/blob/master/LICENSE)
+Code released under the [Apache Software License v2.0](http://www.apache.org/licenses/LICENSE-2.0)

README.md

@@ -1,29 +1,29 @@
 /*
- * This file is part of Swap.
+ * This file is part of node-currency-swap.
  *
- * (C) 2016 Tajawal
- * MIT LICENCE
+ * (C) 2016 tajawal
+ * Apache Software License v2.0
  *
  */
 
 var cache = require('memory-cache');
 
 module.exports = {
-    /**
-     * set exchange rate in memory
-     * @param key
-     * @param data
-     * @param ttl
-     */
-    setExchangeRate: function (key, data, ttl) {
-        cache.put(key, data, ttl);
-    },
+  /**
+   * set exchange rate in memory
+   * @param key
+   * @param data
+   * @param ttl
+   */
+  setExchangeRate: function (key, data, ttl) {
+    cache.put(key, data, ttl);
+  },
 
-    /**
-     * get exchange rate from memory
-     * @param key
-     */
-    getExchangeRate: function (key) {
-        return cache.get(key);
-    }
-};
+  /**
+   * get exchange rate from memory
+   * @param key
+   */
+  getExchangeRate: function (key) {
+    return cache.get(key);
+  }
+};

lib/cache/index.js

@@ -1,8 +1,8 @@
 /*
- * This file is part of Swap.
+ * This file is part of node-currency-swap.
  *
- * (C) 2016 Tajawal
- * MIT LICENCE
+ * (C) 2016 tajawal
+ * Apache Software License v2.0
  *
  */
 
@@ -11,9 +11,9 @@
  * @param message
  */
 var InvalidArgumentException = module.exports = function (message) {
-    Error.captureStackTrace(this, this.constructor);
-    this.name = this.constructor.name;
-    this.message = message;
+  Error.captureStackTrace(this, this.constructor);
+  this.name = this.constructor.name;
+  this.message = message;
 };
 
-require('util').inherits(InvalidArgumentException, Error);
+require('util').inherits(InvalidArgumentException, Error);

lib/error/InvalidArgumentException.js

@@ -1,8 +1,8 @@
 /*
- * This file is part of Swap.
+ * This file is part of node-currency-swap.
  *
- * (C) 2016 Tajawal
- * MIT LICENCE
+ * (C) 2016 tajawal
+ * Apache Software License v2.0
  *
  */
 
@@ -13,9 +13,10 @@ var sprintf = require("sprintf-js").sprintf;
  * @param message
  */
 var UnsupportedCurrencyPairException = module.exports = function (currencyPair, providerName) {
-    Error.captureStackTrace(this, this.constructor);
-    this.name = this.constructor.name;
-    this.message = sprintf('The currency pair "%s" is not supported or "%s" changed the response format', currencyPair, providerName);
+  Error.captureStackTrace(this, this.constructor);
+  this.name = this.constructor.name;
+  this.message = sprintf('The currency pair "%s" is not supported or "%s" changed the response format', currencyPair,
+    providerName);
 };
 
-require('util').inherits(UnsupportedCurrencyPairException, Error);
+require('util').inherits(UnsupportedCurrencyPairException, Error);