Skip to content

Commit 4ae3371

Browse files
meili-bors[bot]meili-botCommanderStormcurquizaStrift
authored
Merge #637
637: Changes related to the next Meilisearch release (v1.13) r=Strift a=meili-bot Related to this issue: meilisearch/integration-guides#314 This PR: - gathers the changes related to the next Meilisearch release (v1.13) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v1.13 is out. ⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.13) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ Co-authored-by: meili-bot <[email protected]> Co-authored-by: Frank Elsinga <[email protected]> Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com> Co-authored-by: Clémentine <[email protected]> Co-authored-by: Laurent Cazanove <[email protected]>
2 parents 548ec19 + d457048 commit 4ae3371

File tree

2 files changed

+12
-37
lines changed

2 files changed

+12
-37
lines changed

.code-samples.meilisearch.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1649,8 +1649,8 @@ get_experimental_features_1: |-
16491649
.unwrap();
16501650
update_experimental_features_1: |-
16511651
let client = Client::new("http://localhost:7700", Some("apiKey"));
1652-
let mut features = ExperimentalFeatures::new(&client);
1653-
features.set_vector_store(true);
1652+
let features = ExperimentalFeatures::new(&client);
1653+
// update the feature you want here
16541654
let res = features
16551655
.update()
16561656
.await

src/features.rs

+10-35
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ use serde::{Deserialize, Serialize};
88
/// Struct representing the experimental features result from the API.
99
#[derive(Clone, Debug, Deserialize)]
1010
#[serde(rename_all = "camelCase")]
11-
pub struct ExperimentalFeaturesResult {
12-
pub vector_store: bool,
13-
}
11+
pub struct ExperimentalFeaturesResult {}
1412

1513
/// Struct representing the experimental features request.
1614
///
@@ -24,29 +22,18 @@ pub struct ExperimentalFeaturesResult {
2422
/// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey");
2523
/// # let client = Client::new(MEILISEARCH_URL, Some(MEILISEARCH_API_KEY)).unwrap();
2624
/// let mut features = ExperimentalFeatures::new(&client);
27-
/// features.set_vector_store(true);
2825
/// ```
2926
#[derive(Debug, Serialize)]
3027
#[serde(rename_all = "camelCase")]
3128
pub struct ExperimentalFeatures<'a, Http: HttpClient> {
3229
#[serde(skip_serializing)]
3330
client: &'a Client<Http>,
34-
#[serde(skip_serializing_if = "Option::is_none")]
35-
pub vector_store: Option<bool>,
3631
}
3732

3833
impl<'a, Http: HttpClient> ExperimentalFeatures<'a, Http> {
3934
#[must_use]
4035
pub fn new(client: &'a Client<Http>) -> Self {
41-
ExperimentalFeatures {
42-
client,
43-
vector_store: None,
44-
}
45-
}
46-
47-
pub fn set_vector_store(&mut self, vector_store: bool) -> &mut Self {
48-
self.vector_store = Some(vector_store);
49-
self
36+
ExperimentalFeatures { client }
5037
}
5138

5239
/// Get all the experimental features
@@ -83,11 +70,10 @@ impl<'a, Http: HttpClient> ExperimentalFeatures<'a, Http> {
8370
/// # let MEILISEARCH_URL = option_env!("MEILISEARCH_URL").unwrap_or("http://localhost:7700");
8471
/// # let MEILISEARCH_API_KEY = option_env!("MEILISEARCH_API_KEY").unwrap_or("masterKey");
8572
/// # let client = Client::new(MEILISEARCH_URL, Some(MEILISEARCH_API_KEY)).unwrap();
86-
/// tokio::runtime::Builder::new_current_thread().enable_all().build().unwrap().block_on(async {
87-
/// let mut features = ExperimentalFeatures::new(&client);
88-
/// features.set_vector_store(true);
89-
/// features.update().await.unwrap();
90-
/// });
73+
/// # tokio::runtime::Builder::new_current_thread().enable_all().build().unwrap().block_on(async {
74+
/// let features = ExperimentalFeatures::new(&client);
75+
/// features.update().await.unwrap();
76+
/// # });
9177
/// ```
9278
pub async fn update(&self) -> Result<ExperimentalFeaturesResult, Error> {
9379
self.client
@@ -111,22 +97,11 @@ mod tests {
11197

11298
#[meilisearch_test]
11399
async fn test_experimental_features_get(client: Client) {
114-
let mut features = ExperimentalFeatures::new(&client);
115-
features.set_vector_store(false);
100+
let features = ExperimentalFeatures::new(&client);
101+
// set feature here, once some exist again
116102
let _ = features.update().await.unwrap();
117103

118-
let res = features.get().await.unwrap();
119-
120-
assert!(!res.vector_store);
121-
}
122-
123-
#[meilisearch_test]
124-
async fn test_experimental_features_enable_vector_store(client: Client) {
125-
let mut features = ExperimentalFeatures::new(&client);
126-
features.set_vector_store(true);
127-
128-
let res = features.update().await.unwrap();
129-
130-
assert!(res.vector_store);
104+
let _res = features.get().await.unwrap();
105+
// assert that the feature has been set once they exist again
131106
}
132107
}

0 commit comments

Comments
 (0)