Skip to content

Commit 6d13f0f

Browse files
committed
chore: remove old xml
1 parent e3397af commit 6d13f0f

File tree

4 files changed

+7
-45
lines changed

4 files changed

+7
-45
lines changed

packages/pluggableWidgets/datagrid-web/src/Datagrid.editorConfig.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,6 @@ export function getProperties(
137137
"columnsHidable",
138138
"configurationAttribute",
139139
"onConfigurationChange",
140-
"filterList",
141-
"filtersPlaceholder",
142140
"filterSectionTitle"
143141
]);
144142
}

packages/pluggableWidgets/datagrid-web/src/Datagrid.xml

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,10 @@
278278
<caption>On selection change</caption>
279279
<description />
280280
</property>
281+
<property key="filtersPlaceholder" type="widgets" required="false">
282+
<caption>Filters placeholder</caption>
283+
<description />
284+
</property>
281285
</propertyGroup>
282286
</propertyGroup>
283287
<propertyGroup caption="Personalization">
@@ -325,36 +329,6 @@
325329
</property>
326330
</propertyGroup>
327331
</propertyGroup>
328-
<propertyGroup caption="Grid wide filtering">
329-
<propertyGroup caption="Grid wide filtering">
330-
<property key="filterList" type="object" isList="true" required="false">
331-
<caption>Filters</caption>
332-
<description>The list of attributes is used by the filter widgets that are placed in the placeholder above the data grid. This enables filtering across multiple attributes or columns instead of limiting to a single column.</description>
333-
<properties>
334-
<propertyGroup caption="General">
335-
<property key="filter" type="attribute" dataSource="../datasource">
336-
<caption>Filter attribute</caption>
337-
<description />
338-
<attributeTypes>
339-
<attributeType name="String" />
340-
<attributeType name="AutoNumber" />
341-
<attributeType name="Boolean" />
342-
<attributeType name="DateTime" />
343-
<attributeType name="Decimal" />
344-
<attributeType name="Enum" />
345-
<attributeType name="Integer" />
346-
<attributeType name="Long" />
347-
</attributeTypes>
348-
</property>
349-
</propertyGroup>
350-
</properties>
351-
</property>
352-
<property key="filtersPlaceholder" type="widgets" required="false">
353-
<caption>Filters placeholder</caption>
354-
<description />
355-
</property>
356-
</propertyGroup>
357-
</propertyGroup>
358332
<propertyGroup caption="Accessibility">
359333
<propertyGroup caption="Aria labels">
360334
<property key="filterSectionTitle" type="textTemplate" required="false">

packages/pluggableWidgets/datagrid-web/src/helpers/state/GridPersonalizationStore.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { FiltersSettingsMap } from "@mendix/filter-commons/typings/settings";
22
import { error, Result, value } from "@mendix/widget-plugin-filtering/result-meta";
3-
import { ObservableFilterHost } from "@mendix/widget-plugin-filtering/typings/observable-filter-host";
3+
import { ObservableFilterHost } from "@mendix/widget-plugin-filtering/typings/ObservableFilterHost";
44
import { action, comparer, computed, IReactionDisposer, makeObservable, reaction } from "mobx";
55
import { DatagridContainerProps } from "../../../typings/DatagridProps";
66
import { ColumnId } from "../../typings/GridColumn";

packages/pluggableWidgets/datagrid-web/typings/DatagridProps.d.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ export type OnClickTriggerEnum = "single" | "double";
5959

6060
export type ConfigurationStorageTypeEnum = "attribute" | "localStorage";
6161

62-
export interface FilterListType {
63-
filter: ListAttributeValue<string | Big | boolean | Date>;
64-
}
65-
6662
export interface ColumnsPreviewType {
6763
showContentAs: ShowContentAsEnum;
6864
attribute: string;
@@ -87,10 +83,6 @@ export interface ColumnsPreviewType {
8783
wrapText: boolean;
8884
}
8985

90-
export interface FilterListPreviewType {
91-
filter: string;
92-
}
93-
9486
export interface DatagridContainerProps {
9587
name: string;
9688
class: string;
@@ -118,15 +110,14 @@ export interface DatagridContainerProps {
118110
onClickTrigger: OnClickTriggerEnum;
119111
onClick?: ListActionValue;
120112
onSelectionChange?: ActionValue;
113+
filtersPlaceholder?: ReactNode;
121114
columnsSortable: boolean;
122115
columnsResizable: boolean;
123116
columnsDraggable: boolean;
124117
columnsHidable: boolean;
125118
configurationStorageType: ConfigurationStorageTypeEnum;
126119
configurationAttribute?: EditableValue<string>;
127120
storeFiltersInPersonalization: boolean;
128-
filterList: FilterListType[];
129-
filtersPlaceholder?: ReactNode;
130121
filterSectionTitle?: DynamicValue<string>;
131122
exportDialogLabel?: DynamicValue<string>;
132123
cancelExportLabel?: DynamicValue<string>;
@@ -166,6 +157,7 @@ export interface DatagridPreviewProps {
166157
onClickTrigger: OnClickTriggerEnum;
167158
onClick: {} | null;
168159
onSelectionChange: {} | null;
160+
filtersPlaceholder: { widgetCount: number; renderer: ComponentType<{ children: ReactNode; caption?: string }> };
169161
columnsSortable: boolean;
170162
columnsResizable: boolean;
171163
columnsDraggable: boolean;
@@ -174,8 +166,6 @@ export interface DatagridPreviewProps {
174166
configurationAttribute: string;
175167
storeFiltersInPersonalization: boolean;
176168
onConfigurationChange: {} | null;
177-
filterList: FilterListPreviewType[];
178-
filtersPlaceholder: { widgetCount: number; renderer: ComponentType<{ children: ReactNode; caption?: string }> };
179169
filterSectionTitle: string;
180170
exportDialogLabel: string;
181171
cancelExportLabel: string;

0 commit comments

Comments
 (0)