Skip to content

Commit 6e562b5

Browse files
r0b1ngjulivan
authored andcommitted
chore: improve texts, use hidden span for icons, prettier
1 parent 2f83858 commit 6e562b5

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

packages/pluggableWidgets/file-uploader-web/src/FileUploader.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,12 +220,12 @@
220220
<description />
221221
</property>
222222
<property key="buttonIsDefault" type="boolean" defaultValue="false">
223-
<caption>Is default</caption>
224-
<description>The action will be triggered by clicking on the file entry.</description>
223+
<caption>Default file action</caption>
224+
<description>When set to Yes, the action will be triggered by clicking on the file entry.</description>
225225
</property>
226226
<property key="buttonIsVisible" type="expression" defaultValue="true">
227-
<caption>Is visible</caption>
228-
<description>The button will be hidden if false is returned.</description>
227+
<caption>Visible</caption>
228+
<description>The button will be hidden when false is returned.</description>
229229
<returnType type="Boolean" />
230230
</property>
231231
</propertyGroup>

packages/pluggableWidgets/file-uploader-web/src/components/ActionsBar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ function DefaultActionsBar(props: ButtonsBarProps) {
5454
return (
5555
<div className={"entry-details-actions"}>
5656
<ActionButton
57-
icon={<div className={"download-icon"} />}
57+
icon={<span className={"download-icon"} aria-hidden={true} />}
5858
title={translations.get("downloadButtonTextMessage")}
5959
action={onViewClick}
6060
isDisabled={!props.store.canDownload}
6161
/>
6262
<ActionButton
63-
icon={<div className={"remove-icon"} />}
63+
icon={<span className={"remove-icon"} aria-hidden={true} />}
6464
title={translations.get("removeButtonTextMessage")}
6565
action={onRemove}
6666
isDisabled={!props.store.canRemove}

packages/pluggableWidgets/file-uploader-web/src/ui/FileUploader.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ Place your custom CSS here
143143
}
144144

145145
.download-icon {
146+
display: inline-block;
146147
height: 24px;
147148
width: 24px;
148149
background-repeat: no-repeat;
@@ -249,6 +250,7 @@ Place your custom CSS here
249250
}
250251

251252
.remove-icon {
253+
display: inline-block;
252254
height: 24px;
253255
width: 24px;
254256
background-repeat: no-repeat;

0 commit comments

Comments
 (0)