Skip to content

Commit 7d03cd2

Browse files
committed
fix: review comments, move colors to vars
1 parent 0ffb755 commit 7d03cd2

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

Diff for: packages/pluggableWidgets/file-uploader-web/src/components/ActionsBar.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ function onDownloadClick(fileUrl: string | undefined): void {
7373
if (!fileUrl) {
7474
return;
7575
}
76-
const url = `${fileUrl}&target=window`;
76+
const url = new URL(fileUrl);
77+
url.searchParams.append("target", "window");
78+
7779
window.open(url, "mendix_file");
7880
}

Diff for: packages/pluggableWidgets/file-uploader-web/src/ui/FileUploader.scss

+8-5
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,13 @@ $file-brand-warning: #eca51c;
77
$file-color-danger-lighter: #f9d9dc;
88
$file-brand-danger: #e33f4e;
99
$file-gray-light: #6c7180;
10+
$file-gray-darker: #3b4251;
1011
$file-brand-success: #3cb33d;
1112

1213
$file-action-icon-hover: #2a39b8;
1314
$file-action-icon-active: #264ae5;
15+
$file-dropzone-color: #8f620b;
16+
$file-progress-background-color: #f0f1f2;
1417

1518
$file-icon: url(../assets/file-icon.svg);
1619
$file-warning-icon: url(../assets/warning-icon.svg);
@@ -92,7 +95,7 @@ Place your custom CSS here
9295
.dropzone-message {
9396
font-size: 12px;
9497
line-height: 17px;
95-
color: #8f620b;
98+
color: var(--file-dropzone-color, $file-dropzone-color);
9699

97100
padding-left: 18px;
98101
margin-bottom: 1em;
@@ -187,7 +190,7 @@ Place your custom CSS here
187190
.entry-details-main-name {
188191
flex: 1;
189192
font-weight: 600;
190-
color: #3b4251;
193+
color: var(--gray-darker, $file-gray-darker);
191194
text-overflow: ellipsis;
192195
overflow: hidden;
193196
white-space: nowrap;
@@ -222,7 +225,7 @@ Place your custom CSS here
222225
background-image: var(--file-remove-icon-hover, $file-remove-icon-hover);
223226
}
224227
.file-action-icon {
225-
color: $file-action-icon-hover;
228+
color: var(--file-action-icon-hover, $file-action-icon-hover);
226229
}
227230
}
228231

@@ -231,7 +234,7 @@ Place your custom CSS here
231234
background-image: var(--file-remove-icon-active, $file-remove-icon-active);
232235
}
233236
.file-action-icon {
234-
color: $file-action-icon-active;
237+
color: var(--file-action-icon-active, $file-action-icon-active);
235238
}
236239
}
237240

@@ -262,7 +265,7 @@ Place your custom CSS here
262265

263266
height: 4px;
264267
border-radius: 2px;
265-
background-color: #f0f1f2;
268+
background-color: var(--file-progress-background-color, $file-progress-background-color);
266269
margin: 5px 0;
267270
width: 100%;
268271
overflow: hidden;

0 commit comments

Comments
 (0)