Skip to content

Commit b7687b9

Browse files
authored
[WC-1566]: Duplicate id in DG2 (#234)
2 parents 3e712b4 + 53183dc commit b7687b9

File tree

6 files changed

+7
-19
lines changed

6 files changed

+7
-19
lines changed

packages/modules/data-widgets/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "data-widgets",
33
"moduleName": "Data Widgets",
4-
"version": "2.5.8",
4+
"version": "2.5.9",
55
"license": "Apache-2.0",
66
"copyright": "© Mendix Technology BV 2022. All rights reserved.",
77
"private": true,

packages/pluggableWidgets/datagrid-web/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- We fixed an issue with duplicate id attribute.
12+
913
## [2.4.3] - 2022-12-12
1014

1115
### Added

packages/pluggableWidgets/datagrid-web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "datagrid-web",
33
"widgetName": "Datagrid",
4-
"version": "2.4.3",
4+
"version": "2.4.4",
55
"description": "",
66
"copyright": "© Mendix Technology BV 2022. All rights reserved.",
77
"private": true,

packages/pluggableWidgets/datagrid-web/src/components/Header.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ export function Header(props: HeaderProps): ReactElement {
116116
>
117117
<div
118118
className={classNames("column-header", canSort ? "clickable" : "", props.className)}
119-
id={props.column.id}
120119
style={{ pointerEvents: props.isDragging ? "none" : undefined }}
121120
{...(canSort ? sortProps : undefined)}
122121
>

packages/pluggableWidgets/datagrid-web/src/components/__tests__/__snapshots__/Table.spec.tsx.snap

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ exports[`Table renders the structure correctly 1`] = `
3434
>
3535
<div
3636
class="column-header align-column-left"
37-
id="0"
3837
>
3938
<span>
4039
Test
@@ -97,7 +96,6 @@ exports[`Table renders the structure correctly for preview when no header is pro
9796
>
9897
<div
9998
class="column-header align-column-center"
100-
id="0"
10199
>
102100
<span>
103101
 
@@ -160,7 +158,6 @@ exports[`Table renders the structure correctly with column alignments 1`] = `
160158
>
161159
<div
162160
class="column-header align-column-center"
163-
id="0"
164161
>
165162
<span>
166163
Test
@@ -181,7 +178,6 @@ exports[`Table renders the structure correctly with column alignments 1`] = `
181178
>
182179
<div
183180
class="column-header align-column-right"
184-
id="1"
185181
>
186182
<span>
187183
Test 2
@@ -250,7 +246,6 @@ exports[`Table renders the structure correctly with custom filtering 1`] = `
250246
>
251247
<div
252248
class="column-header align-column-left"
253-
id="0"
254249
>
255250
<span>
256251
Test
@@ -317,7 +312,6 @@ exports[`Table renders the structure correctly with dragging 1`] = `
317312
>
318313
<div
319314
class="column-header align-column-left"
320-
id="0"
321315
>
322316
<span>
323317
Test
@@ -380,7 +374,6 @@ exports[`Table renders the structure correctly with dynamic row class 1`] = `
380374
>
381375
<div
382376
class="column-header align-column-left"
383-
id="0"
384377
>
385378
<span>
386379
Test
@@ -443,7 +436,6 @@ exports[`Table renders the structure correctly with empty placeholder 1`] = `
443436
>
444437
<div
445438
class="column-header align-column-left"
446-
id="0"
447439
>
448440
<span>
449441
Test
@@ -506,7 +498,6 @@ exports[`Table renders the structure correctly with filtering 1`] = `
506498
>
507499
<div
508500
class="column-header align-column-left"
509-
id="0"
510501
>
511502
<span>
512503
Test
@@ -584,7 +575,6 @@ exports[`Table renders the structure correctly with header filters and a11y 1`]
584575
>
585576
<div
586577
class="column-header align-column-left"
587-
id="0"
588578
>
589579
<span>
590580
Test
@@ -650,7 +640,6 @@ exports[`Table renders the structure correctly with header wrapper 1`] = `
650640
>
651641
<div
652642
class="column-header align-column-left"
653-
id="0"
654643
>
655644
<span>
656645
Test
@@ -714,7 +703,6 @@ exports[`Table renders the structure correctly with hiding 1`] = `
714703
>
715704
<div
716705
class="column-header align-column-left"
717-
id="0"
718706
>
719707
<span>
720708
Test
@@ -815,7 +803,6 @@ exports[`Table renders the structure correctly with paging 1`] = `
815803
>
816804
<div
817805
class="column-header align-column-left"
818-
id="0"
819806
>
820807
<span>
821808
Test
@@ -924,7 +911,6 @@ exports[`Table renders the structure correctly with resizing 1`] = `
924911
>
925912
<div
926913
class="column-header align-column-left"
927-
id="0"
928914
>
929915
<span>
930916
Test
@@ -987,7 +973,6 @@ exports[`Table renders the structure correctly with sorting 1`] = `
987973
>
988974
<div
989975
class="column-header align-column-left"
990-
id="0"
991976
>
992977
<span>
993978
Test

packages/pluggableWidgets/datagrid-web/src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="Datagrid" version="2.4.3" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="Datagrid" version="2.4.4" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="Datagrid.xml" />
66
</widgetFiles>

0 commit comments

Comments
 (0)