more fixing for insight

Author: phiamo

.gitignore

@@ -24,15 +24,6 @@ composer.phar
 
 /.idea
 
-# OS generated files #
-######################
-.DS_Store
-.DS_Store?
-._*
-.Spotlight-V100
-.Trashes
-ehthumbs.db
-Thumbs.db
 
 # Keep .gitkeep #
 #################

.scrutinizer.yml

@@ -1,4 +1,4 @@
 checks:
     php:
         code_rating: true
-        duplication: true
+        duplication: true

Command/BaseBootstrapSymlinkCommand.php

@@ -217,7 +217,7 @@ protected function getBootstrapPathsFromUser()
 ;
         $this->output->writeln(array(
             '',
-            $this->getHelperSet()->get('formatter')->formatBlock($text, $style = 'bg=blue;fg=white', true),
+            $this->getHelperSet()->get('formatter')->formatBlock($text, 'bg=blue;fg=white', true),
             '',
         ));
 

Form/Extension/StaticTextExtension.php

@@ -60,7 +60,7 @@ public function configureOptions(OptionsResolver $resolver)
     public function buildView(FormView $view, FormInterface $form, array $options)
     {
         $view->vars['static_text'] = $options['static_text'];
-        if ($options['static_text'] == true) {
+        if ($options['static_text'] === true) {
             $view->vars['disabled'] = true;
         }
     }

Form/Extension/WidgetCollectionFormTypeExtension.php

@@ -46,7 +46,7 @@ public function __construct(array $options)
     public function buildView(FormView $view, FormInterface $form, array $options)
     {
         if (in_array('collection', $view->vars['block_prefixes'])) {
-            if ($options['widget_add_btn'] != null && !is_array($options['widget_add_btn'])) {
+            if ($options['widget_add_btn'] !== null && !is_array($options['widget_add_btn'])) {
                 throw new InvalidArgumentException('The "widget_add_btn" option must be an "array".');
             }
 
@@ -59,7 +59,7 @@ public function buildView(FormView $view, FormInterface $form, array $options)
         }
 
         if ($view->parent && in_array('collection', $view->parent->vars['block_prefixes'])) {
-            if ($options['widget_remove_btn'] != null && !is_array($options['widget_remove_btn'])) {
+            if ($options['widget_remove_btn'] !== null && !is_array($options['widget_remove_btn'])) {
                 throw new InvalidArgumentException('The "widget_remove_btn" option must be an "array".');
             }
 

Form/Type/FormActionsType.php

@@ -41,7 +41,10 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     protected function createButton($builder, $name, $config)
     {
         $options = (isset($config['options'])) ? $config['options'] : array();
-        $button = $builder->add($name, $config['type'], $options);
+
+        $builder->add($name, $config['type'], $options);
+
+        return $builder;
     }
 
     /**