Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message format for the graphql-ws protocol #1132

Open
ReneeSlamka opened this issue Jan 27, 2025 · 1 comment
Open

Incorrect error message format for the graphql-ws protocol #1132

ReneeSlamka opened this issue Jan 27, 2025 · 1 comment

Comments

@ReneeSlamka
Copy link

Hi, I've found a gap in support for the legacy graphql-ws protocol. The spec indicates that for error messages the payload should be a single "Error" object, but currently Mercurius only adheres to the graphql-transport-ws protocol error format by always returning an array of GraphQL errors.

I realize that the graphql-ws protocol is considered deprecated, but given the docs state both are supported I think this is worth addressing. Thanks!

@mcollina
Copy link
Collaborator

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants