Skip to content

Commit 657747a

Browse files
committed
TST: remove wrong test testing the wrong thing
The test tried to test the effect of setting the MACOS_BUILD_TARGET environment variable on the produced wheel tags, however there is bug for which the emitted tags are always compared to the tag for the current platform. The environment variable has no effect on the wheel tags. Remove the bogus test.
1 parent a500136 commit 657747a

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

tests/test_tags.py

-16
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import os
66
import pathlib
77
import platform
8-
import re
98
import sysconfig
109

1110
from collections import defaultdict
@@ -93,18 +92,3 @@ def test_tag_mixed_abi(monkeypatch):
9392
'platlib': [f'extension{ABI3SUFFIX}', f'another{SUFFIX}'],
9493
})
9594
assert str(builder.tag) == f'{INTERPRETER}-{ABI}-{PLATFORM}'
96-
97-
98-
@pytest.mark.skipif(platform.system() != 'Darwin', reason='macOS specific test')
99-
def test_tag_macos_build_target(monkeypatch):
100-
monkeypatch.setenv('MACOS_BUILD_TARGET', '12.0')
101-
builder = wheel_builder_test_factory(monkeypatch, {
102-
'platlib': [f'extension{SUFFIX}'],
103-
})
104-
assert builder.tag.platform == re.sub(r'\d+\.\d+', '12.0', PLATFORM)
105-
106-
monkeypatch.setenv('MACOS_BUILD_TARGET', '10.9')
107-
builder = wheel_builder_test_factory(monkeypatch, {
108-
'platlib': [f'extension{SUFFIX}'],
109-
})
110-
assert builder.tag.platform == re.sub(r'\d+\.\d+', '10.9', PLATFORM)

0 commit comments

Comments
 (0)