Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default formatter to the official one #274

Closed
asd-a opened this issue Jan 18, 2025 · 2 comments · Fixed by #275
Closed

Change the default formatter to the official one #274

asd-a opened this issue Jan 18, 2025 · 2 comments · Fixed by #275

Comments

@asd-a
Copy link

asd-a commented Jan 18, 2025

meson has supported format (fmt) subcommand, since 1.5, and 1.6.1 released recently.
So we could use the official one that do not need ex-dependency.

@tristan957
Copy link
Member

@Totto16 did your PR cover this? I can't remember

@Totto16
Copy link
Contributor

Totto16 commented Jan 28, 2025

@Totto16 did your PR cover this? I can't remember

Not really, In the package.json the default value for mesonbuild.formatting.provider is still muon. I thought, that the generic code to handle formatters already handles multiple formatters correctly (use meson, if muon isn't present or vice versa) but he doesn't. But it seems fairly straightforward to do that, so I might as well do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants