Skip to content

Commit fb7facf

Browse files
authored
Update mast launcher info and adjust for latest torchtitan (#229)
* Update mast launcher info Following https://www.internalfb.com/diff/D84945310 * remove print_args option deleted from upstream torchtitan * Fix llama3_auto_parallel name to match upstream torchtitan/autoparallel
1 parent c379849 commit fb7facf

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

mast/.torchxconfig

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,14 @@ conda_path_in_fbpkg = conda
33
activate_conda = False
44
fbpkg_ids = fb-py-spy:prod
55
hpcIdentity = pytorch_distributed
6-
rmAttribution = pytorch4all_clients_approved
6+
rmAttribution = msl_infra_pytorch_dev
77
workspace_fbpkg_name = torchtitan_workspace
88
conda_pack_ignore_missing_files = True
99
git = False
1010
hpcJobOncall = meta_conda
1111
modelTypeName = gen_ai_conda
12-
hpcClusterUuid = MastProdCluster
12+
hpcClusterUuid = MastGenAICluster
13+
localityConstraints = region;gtn
1314
forceSingleRegion = False
1415
use_caf = False
1516

mast/run_torchtitan.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,5 +78,4 @@ python torchtitan/train.py \
7878
--validation.dataset_path "${dataset_path}" \
7979
--metrics.save_tb_folder "${save_tb_folder}" \
8080
--metrics.disable_color_printing \
81-
--job.print_args \
8281
$overrides

mast/sweep.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,12 @@ def maybe_find_pulp(maybe_path: Optional[str] = None) -> Optional[str]:
104104
],
105105
"llama3_autop_1d_compile": llama3_1d_common_opts
106106
+ [
107-
"--model.name=llama3_auto_parallel",
107+
"--model.name=auto_parallel.llama3",
108108
"--compile.enable",
109109
],
110110
"llama3_autop_1d_compile_bucket_reorder": llama3_1d_common_opts
111111
+ [
112-
"--model.name=llama3_auto_parallel",
112+
"--model.name=auto_parallel.llama3",
113113
"--compile.enable",
114114
"--experimental.bucket_all_gathers_fx=fsdp",
115115
"--experimental.bucket_reduce_scatters_fx=fsdp",
@@ -125,12 +125,12 @@ def maybe_find_pulp(maybe_path: Optional[str] = None) -> Optional[str]:
125125
],
126126
"llama3_autop_2d_compile": llama3_2d_common_opts
127127
+ [
128-
"--model.name=llama3_auto_parallel",
128+
"--model.name=auto_parallel.llama3",
129129
"--compile.enable",
130130
],
131131
"llama3_autop_2d_compile_bucket_reorder": llama3_2d_common_opts
132132
+ [
133-
"--model.name=llama3_auto_parallel",
133+
"--model.name=auto_parallel.llama3",
134134
"--compile.enable",
135135
"--experimental.bucket_all_gathers_fx=fsdp",
136136
"--experimental.bucket_reduce_scatters_fx=fsdp",
@@ -153,13 +153,13 @@ def maybe_find_pulp(maybe_path: Optional[str] = None) -> Optional[str]:
153153
| {
154154
"llama3_autop_1d_compile_ruisi_bucket_reorder": llama3_1d_common_opts
155155
+ [
156-
"--model.name=llama3_auto_parallel",
156+
"--model.name=auto_parallel.llama3",
157157
"--compile.enable",
158158
"--experimental.enable_simplefsdp_passes",
159159
],
160160
"llama3_autop_2d_compile_ruisi_bucket_reorder": llama3_2d_common_opts
161161
+ [
162-
"--model.name=llama3_auto_parallel",
162+
"--model.name=auto_parallel.llama3",
163163
"--compile.enable",
164164
"--experimental.enable_simplefsdp_passes",
165165
],

0 commit comments

Comments
 (0)