Skip to content

Commit 0a014f8

Browse files
mlunar-metameta-codesync[bot]
authored andcommitted
Add Thrift package to analyzer .thrift files (#2411)
Summary: Pull Request resolved: #2411 Add `package "meta.com/comms/analyzer"` to the 3 Thrift files under `comms/analyzer/if/` that were missing it, and remove the `thrift.AllowLegacyMissingUris` annotation that was only needed because the package was empty. This resolves T262746691. Reviewed By: vitaut Differential Revision: D104105074 fbshipit-source-id: d79aa75b266d943cdf862a74054286688add3304
1 parent f6946fb commit 0a014f8

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

comms/analyzer/if/CommsTracingService.thrift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ cpp_include "<unordered_set>"
1010
include "thrift/annotation/cpp.thrift"
1111
include "thrift/annotation/thrift.thrift"
1212

13-
@thrift.AllowLegacyMissingUris
14-
package;
13+
package "meta.com/comms/analyzer"
1514

1615
typedef i64 GlobalRank
1716
typedef string CommHash

comms/analyzer/if/NCCLAnalyzerState.thrift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ namespace cpp2 facebook.comms.analyzer
44

55
include "thrift/annotation/thrift.thrift"
66

7-
@thrift.AllowLegacyMissingUris
8-
package;
7+
package "meta.com/comms/analyzer"
98

109
// Numerical rank identifier within a communicator.
1110
typedef i64 CommRank

comms/analyzer/if/NCCLAnalyzerVerdict.thrift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
include "thrift/annotation/cpp.thrift"
44
include "thrift/annotation/thrift.thrift"
55

6-
@thrift.AllowLegacyMissingUris
7-
package;
6+
package "meta.com/comms/analyzer"
87

98
cpp_include "<unordered_set>"
109

0 commit comments

Comments
 (0)