Skip to content

Log config to output only on rank zero #2700

Description

@joecummings

Currently, we call config.log_config in the recipe_main which means this logs to every device.

We really only need this to happen once. See callsite here: https://github.com/pytorch/torchtune/blob/dd6764189d7e6ecc0f59902afb657dd60ee74b13/recipes/full_finetune_distributed.py#L1093

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    best practiceThings we should be doing but aren'tcommunity help wantedWe would love the community's help completing this issuegood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions