Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support appsv1.ReplicaSet as a target #2940

Open
waveywaves opened this issue Nov 27, 2024 · 1 comment
Open

feat: Support appsv1.ReplicaSet as a target #2940

waveywaves opened this issue Nov 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@waveywaves
Copy link

waveywaves commented Nov 27, 2024

I had a failure running the below command

 mirrord exec -t replicationcontroller/guestbook go run main.go 

was hoping to be able to set a pod created by the replication controller as a target to only learn that replicationcontroller and replicasets are not part of the supported workload types.

- Valid format:
          >> deployment/<deployment-name>[/container/container-name]
          >> deploy/<deployment-name>[/container/container-name]
          >> pod/<pod-name>[/container/container-name]
          >> job/<job-name>[/container/container-name]
          >> cronjob/<cronjob-name>[/container/container-name]
          >> statefulset/<statefulset-name>[/container/container-name]

This feature will help support more workload types for mirrored.

Edit: ReplicationController is legacy API now superseded with Deployment and ReplicaSet. Updated this issue only as a request to add support for replicasets.

@waveywaves waveywaves added the enhancement New feature or request label Nov 27, 2024
Copy link

linear bot commented Nov 27, 2024

@waveywaves waveywaves changed the title feat: Support v1.ReplicationController and appsv1.ReplicaSet as viable targets feat: Support appsv1.ReplicaSet as a target Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant