Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TcpConnectionSniffer drops connection data senders only when packet is received #2995

Open
Razz4780 opened this issue Dec 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Razz4780
Copy link
Contributor

Bug Description

TcpConnectionSniffer sends mirrored data to the clients via tokio's broadcast channels. The channel is correctly created when a new session packet is received. However, it is only removed when we receive a packet and detect that either:

  1. This packet closes the connection - good.
  2. All data receivers are dropped - bad. We should drop the channel as soon as all receivers are dropped, without waiting for the packet to come

Steps to Reproduce


Backtrace

No response

mirrord layer logs

No response

mirrord intproxy logs

No response

mirrord agent logs

No response

mirrord config

No response

mirrord CLI version

No response

mirrord-agent version

3.128.0

mirrord-operator version (if relevant)

No response

plugin kind and version (if relevant)

No response

Your operating system and version


Local process


Local process version

No response

Additional Info

No response

@Razz4780 Razz4780 added the bug Something isn't working label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant