Skip to content

DogstatsdExporter: max_payload_len behavior difference #560

Open
@nappairam

Description

@nappairam

Thanks for taking time to review my PR for global labels, namespace.
#555

I observed another difference today, when compared to the v0.8 of dogstatsd exporter.
Each metric is send in a separate UDP packets, instead of aggregating.

Version 0.8 supported a parameter max_packet_size. The exporter will aggregate the metrics and split based on the above size and send as UDP packets.
https://github.com/dialtone/metrics-exporter-dogstatsd/blob/a623e5c1463f063c1377386b2754f1e79cc5435a/src/builder.rs#L466

Current version 0.9 has a similar parameter maximum_payload_length

pub fn with_maximum_payload_length(

But instead of aggregating the metrics in a single packet, it simply restricts the maximum size of the single metric.

Aggregating metrics is very useful to servers with large amount of metrics, since exporter do not need to spam UDP packets and waste CPU cycles.

Could you consider adding this aggregation support ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-exporterComponent: exporters such as Prometheus, TCP, etc.E-simpleEffort: simple.T-requestType: request.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions