comment

Author: chmeynard

src/CheckedFile.cpp

@@ -238,10 +238,10 @@ CheckedFile::CheckedFile( const char *input, uint64_t size, ReadChecksumPolicy p
 int CheckedFile::open64( const ustring &fileName, int flags, int mode )
 {
 #if defined( _MSC_VER )
-// Ref: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/sopen-s-wsopen-s
 
 // Handle UTF-8 file names - Windows requires conversion to UTF-16
 #if ( ( defined( _MSVC_LANG ) && _MSVC_LANG >= 201703L ) || __cplusplus >= 201703L )
+// Ref: https://learn.microsoft.com/en-us/windows/win32/api/stringapiset/nf-stringapiset-multibytetowidechar
    std::wstring widePath;
    int sizeUtf16 = ::MultiByteToWideChar( CP_UTF8, 0, fileName.c_str(), -1, NULL, 0 );
    if ( sizeUtf16 > 0 )
@@ -256,10 +256,12 @@ int CheckedFile::open64( const ustring &fileName, int flags, int mode )
                             "Error in converting file name to UTF16. fileName=" + fileName );
    }
 #else
+// Until C++17
    std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> converter;
    std::wstring widePath = converter.from_bytes( fileName );
 #endif
 
+// Ref: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/sopen-s-wsopen-s
    int handle;
    errno_t err = _wsopen_s( &handle, widePath.c_str(), flags, _SH_DENYNO, mode );
    if ( err != 0 )