(refactor/test): export fixtures as objects named <prefix>F

- better organization to combine related fixture data as one object
- naming as <prefix>F makes it more clear that we're referencing a
  fixture in the code, similar to e.g. TypeScript I<suffix>

Author: agilgur5

src/index.spec.js

@@ -3,7 +3,7 @@ import { mount } from 'enzyme'
 import React from 'react'
 
 import SignatureCanvas from './index.js'
-import { props, sigPadOptions, dotData, canvasProps, trimmedSize } from '../test-utils/fixtures.js'
+import { propsF, dotF } from '../test-utils/fixtures.js'
 
 test('mounts canvas and instance properly', () => {
   const wrapper = mount(<SignatureCanvas />)
@@ -19,11 +19,11 @@ describe('props are set and updated correctly', () => {
   })
 
   test('mounted initial props and options should match', () => {
-    const instance = mount(<SignatureCanvas {...props} />).instance()
+    const instance = mount(<SignatureCanvas {...propsF.all} />).instance()
     const sigPad = instance.getSignaturePad()
 
-    expect(instance.props).toMatchObject(props)
-    expect(sigPad).toMatchObject(sigPadOptions)
+    expect(instance.props).toMatchObject(propsF.all)
+    expect(sigPad).toMatchObject(propsF.sigPadOptions)
   })
 
   test('updated props and options should match', () => {
@@ -32,13 +32,13 @@ describe('props are set and updated correctly', () => {
     const sigPad = instance.getSignaturePad()
 
     // default props and options should not match new ones
-    expect(instance.props).not.toMatchObject(props)
-    expect(sigPad).not.toMatchObject(sigPadOptions)
+    expect(instance.props).not.toMatchObject(propsF.all)
+    expect(sigPad).not.toMatchObject(propsF.sigPadOptions)
 
     // should match when updated
-    wrapper.setProps(props)
-    expect(instance.props).toMatchObject(props)
-    expect(sigPad).toMatchObject(sigPadOptions)
+    wrapper.setProps(propsF.all)
+    expect(instance.props).toMatchObject(propsF.all)
+    expect(sigPad).toMatchObject(propsF.sigPadOptions)
   })
 })
 
@@ -53,20 +53,20 @@ describe('SigCanvas wrapper methods return equivalent to SigPad', () => {
   })
 
   test('fromData should be equivalent', () => {
-    rSigPad.fromData(dotData)
+    rSigPad.fromData(dotF.data)
     const rData = rSigPad.toData()
-    expect(rData).toBe(dotData)
+    expect(rData).toBe(dotF.data)
     expect(rData).toBe(sigPad.toData())
 
     // test reverse as both froms should be equivalent
-    sigPad.fromData(dotData)
+    sigPad.fromData(dotF.data)
     const data = sigPad.toData()
     expect(rData).toBe(data)
     expect(rSigPad.toData()).toBe(data)
   })
 
   test('toDataURL should be equivalent', () => {
-    rSigPad.fromData(dotData)
+    rSigPad.fromData(dotF.data)
     expect(rSigPad.toDataURL()).toBe(sigPad.toDataURL())
     expect(rSigPad.toDataURL('image/jpg')).toBe(sigPad.toDataURL('image/jpg'))
     expect(rSigPad.toDataURL('image/jpg', 0.7)).toBe(sigPad.toDataURL('image/jpg', 0.7))
@@ -75,23 +75,23 @@ describe('SigCanvas wrapper methods return equivalent to SigPad', () => {
 
   test('fromDataURL should be equivalent', () => {
     // convert data fixture to dataURL
-    rSigPad.fromData(dotData)
-    const dotDataURL = rSigPad.toDataURL()
+    rSigPad.fromData(dotF.data)
+    const dotFDataURL = rSigPad.toDataURL()
 
-    rSigPad.fromDataURL(dotDataURL)
+    rSigPad.fromDataURL(dotFDataURL)
     const rDataURL = rSigPad.toDataURL()
-    expect(rDataURL).toBe(dotDataURL)
+    expect(rDataURL).toBe(dotFDataURL)
     expect(rDataURL).toBe(sigPad.toDataURL())
 
     // test reverse as both froms should be equivalent
-    sigPad.fromDataURL(dotDataURL)
+    sigPad.fromDataURL(dotFDataURL)
     const dataURL = sigPad.toDataURL()
     expect(rDataURL).toBe(dataURL)
     expect(rSigPad.toDataURL()).toBe(dataURL)
   })
 
   test('isEmpty & clear should be equivalent', () => {
-    rSigPad.fromData(dotData)
+    rSigPad.fromData(dotF.data)
     let isEmpty = rSigPad.isEmpty()
     expect(isEmpty).toBe(false)
     expect(isEmpty).toBe(sigPad.isEmpty())
@@ -103,7 +103,7 @@ describe('SigCanvas wrapper methods return equivalent to SigPad', () => {
     expect(isEmpty).toBe(sigPad.isEmpty())
 
     // test reverse
-    sigPad.fromData(dotData)
+    sigPad.fromData(dotF.data)
     isEmpty = rSigPad.isEmpty()
     expect(isEmpty).toBe(false)
     expect(isEmpty).toBe(sigPad.isEmpty())
@@ -118,9 +118,9 @@ describe('SigCanvas wrapper methods return equivalent to SigPad', () => {
 
 describe('get methods return correct canvases', () => {
   const instance = mount(
-    <SignatureCanvas canvasProps={canvasProps} />
+    <SignatureCanvas canvasProps={dotF.canvasProps} />
   ).instance()
-  instance.fromData(dotData)
+  instance.fromData(dotF.data)
 
   test('getCanvas should return the same underlying canvas', () => {
     const canvas = instance.getCanvas()
@@ -129,7 +129,7 @@ describe('get methods return correct canvases', () => {
 
   test('getTrimmedCanvas should return a trimmed canvas', () => {
     const trimmed = instance.getTrimmedCanvas()
-    expect(trimmed.width).toBe(trimmedSize.width)
-    expect(trimmed.height).toBe(trimmedSize.height)
+    expect(trimmed.width).toBe(dotF.trimmedSize.width)
+    expect(trimmed.height).toBe(dotF.trimmedSize.height)
   })
 })

test-utils/fixtures.js

@@ -1,5 +1,5 @@
 // signature_pad options
-export const sigPadOptions = {
+const sigPadOptions = {
   velocityFilterWeight: 0.8,
   minWidth: 0.6,
   maxWidth: 2.6,
@@ -16,10 +16,12 @@ const rSCProps = {
   clearOnResize: false
 }
 // should all be different from the defaults
-export const props = { ...sigPadOptions, ...rSCProps }
+const props = { ...sigPadOptions, ...rSCProps }
+export const propsF = { sigPadOptions, all: props }
 
-export const dotData = [
+const dotData = [
   [{ x: 466.59375, y: 189, time: 1564339579755, color: 'black' }]
 ]
-export const canvasProps = { width: 1011, height: 326 }
-export const trimmedSize = { width: 4, height: 4 }
+const canvasProps = { width: 1011, height: 326 }
+const trimmedSize = { width: 4, height: 4 }
+export const dotF = { data: dotData, canvasProps, trimmedSize }