codal_app/microbithal: Add sound effect default constants.

Signed-off-by: Damien George <[email protected]>

Author: dpgeorge

src/codal_app/microbithal.cpp

@@ -25,11 +25,23 @@
  */
 
 #include "main.h"
+#include "microbithal.h"
 #include "MicroBitDevice.h"
 #include "neopixel.h"
 
 #define HAL_ARRAY_SIZE(a) (sizeof(a) / sizeof((a)[0]))
 
+// It's not possible to include the CODAL header file that defines the SFX_DEFAULT_xxx
+// constants in C code, because that CODAL header file is C++.  Instead we define our
+// own MICROBIT_HAL_SFX_DEFAULT_xxx versions of the constants in a C-compatible header
+// file, and assert here that they have the same value as the CODAL constants.
+static_assert(MICROBIT_HAL_SFX_DEFAULT_VIBRATO_PARAM == SFX_DEFAULT_VIBRATO_PARAM, "");
+static_assert(MICROBIT_HAL_SFX_DEFAULT_VIBRATO_STEPS == SFX_DEFAULT_VIBRATO_STEPS, "");
+static_assert(MICROBIT_HAL_SFX_DEFAULT_TREMOLO_PARAM == SFX_DEFAULT_TREMOLO_PARAM, "");
+static_assert(MICROBIT_HAL_SFX_DEFAULT_TREMOLO_STEPS == SFX_DEFAULT_TREMOLO_STEPS, "");
+static_assert(MICROBIT_HAL_SFX_DEFAULT_WARBLE_PARAM == SFX_DEFAULT_WARBLE_PARAM, "");
+static_assert(MICROBIT_HAL_SFX_DEFAULT_WARBLE_STEPS == SFX_DEFAULT_WARBLE_STEPS, "");
+
 NRF52Pin *const pin_obj[] = {
     &uBit.io.P0,
     &uBit.io.P1,
@@ -83,8 +95,6 @@ static uint16_t button_state[2];
 
 extern "C" {
 
-#include "microbithal.h"
-
 void microbit_hal_background_processing(void) {
     // This call takes about 200us.
     Event(DEVICE_ID_SCHEDULER, DEVICE_SCHEDULER_EVT_IDLE);

src/codal_app/microbithal.h

@@ -103,6 +103,14 @@ extern "C" {
 #define MICROBIT_HAL_LOG_TIMESTAMP_HOURS            (36000)
 #define MICROBIT_HAL_LOG_TIMESTAMP_DAYS             (864000)
 
+// These default fx values are the same as defined by CODAL, but here in a C-compatible header.
+#define MICROBIT_HAL_SFX_DEFAULT_VIBRATO_PARAM      (2)
+#define MICROBIT_HAL_SFX_DEFAULT_VIBRATO_STEPS      (512)
+#define MICROBIT_HAL_SFX_DEFAULT_TREMOLO_PARAM      (3)
+#define MICROBIT_HAL_SFX_DEFAULT_TREMOLO_STEPS      (900)
+#define MICROBIT_HAL_SFX_DEFAULT_WARBLE_PARAM       (2)
+#define MICROBIT_HAL_SFX_DEFAULT_WARBLE_STEPS       (700)
+
 void microbit_hal_idle(void);
 
 __attribute__((noreturn)) void microbit_hal_reset(void);