Fix: storage account 403 error when creating new tre env

[ShakutaiGit]

Resolves #4405

What is being addressed

• Ensuring role propagation before execution: The script now properly waits for both Storage Account Contributor and Storage Blob Data Contributor roles to be assigned before attempting storage operations.
• Refactoring role assignment check: Instead of checking a single role, the script now verifies both roles are assigned before proceeding, reducing failures due to role propagation delays.

Testing:

• branch before the change (with the issue) https://github.com/microsoft/AzureTRE/actions/runs/13544133660
• test of a new branch from the PR branch (after the change in the PR) https://github.com/microsoft/AzureTRE/actions/runs/13783862890 https://github.com/microsoft/AzureTRE/actions/runs/13767557310

[github-actions]

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c1e5441.

♻️ This comment has been updated with latest results.

[ShakutaiGit]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13545863577 (with refid ecb751e8)

(in response to this comment from @ShakutaiGit)

[ShakutaiGit]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13769103068 (with refid ecb751e8)

(in response to this comment from @ShakutaiGit)

[ShakutaiGit]

/test

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13783417156 (with refid ecb751e8)

(in response to this comment from @ShakutaiGit)

[marrobi]

LGTM. Thanks tidy now.

[ShakutaiGit]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13783417156 (with refid ecb751e8)

(in response to this comment from @ShakutaiGit)

tests passed

[ShakutaiGit]

/test-force-approve

[github-actions]

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit a60f169)

(in response to this comment from @ShakutaiGit)

[ShakutaiGit]

/test-force-approve

[github-actions]

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit c1e5441)

(in response to this comment from @ShakutaiGit)