Skip to content

Conversation

zhiyuanliang-ms
Copy link
Contributor

@zhiyuanliang-ms zhiyuanliang-ms commented Dec 9, 2024

Why this PR?

Support recurrence for time window filter. Also renamed some files to follow the naming convention.

Time window filter schema: https://github.com/microsoft/FeatureManagement/blob/main/Schema/FeatureFilters/Microsoft.TimeWindow.v2.0.0.schema.json

Reference:
#266
#522
Doc

@zhiyuanliang-ms zhiyuanliang-ms marked this pull request as ready for review December 10, 2024 10:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 18 changed files in this pull request and generated no suggestions.

Files not reviewed (10)
  • package.json: Language not supported
  • src/filter/TimeWindowFilter.ts: Evaluated as low risk
  • src/featureManager.ts: Evaluated as low risk
  • test/noFilters.test.ts: Evaluated as low risk
  • test/featureManager.test.ts: Evaluated as low risk
  • test/targetingFilter.test.ts: Evaluated as low risk
  • src/index.ts: Evaluated as low risk
  • src/filter/targetingFilter.ts: Evaluated as low risk
  • src/filter/recurrence/validator.ts: Evaluated as low risk
  • src/filter/utils.ts: Evaluated as low risk
Comments skipped due to low confidence (5)

src/filter/recurrence/evaluator.ts:32

  • [nitpick] The function name 'FindPreviousRecurrence' should be in camelCase to maintain consistency with the rest of the codebase. Consider renaming it to 'findPreviousRecurrence'.
function FindPreviousRecurrence(time: Date, recurrenceSpec: RecurrenceSpec): RecurrenceState | undefined {

src/filter/recurrence/evaluator.ts:60

  • [nitpick] The function name 'FindPreviousDailyRecurrence' should be in camelCase to maintain consistency with the rest of the codebase. Consider renaming it to 'findPreviousDailyRecurrence'.
function FindPreviousDailyRecurrence(time: Date, recurrenceSpec: RecurrenceSpec): RecurrenceState {

src/filter/recurrence/evaluator.ts:43

  • The error message 'Unsupported recurrence pattern type.' could be more specific. Consider providing the unsupported pattern type in the message.
throw new Error("Unsupported recurrence pattern type.");

src/filter/timeWindowFilter.ts:21

  • [nitpick] The type name 'RecurrenceParameter' is inconsistent with the naming convention of other parameter types. Consider renaming it to 'RecurrenceParameters'.
export type RecurrenceParameter = {

src/filter/recurrence/utils.ts:34

  • [nitpick] The parameter name 'timezoneOffset' is ambiguous as it is in milliseconds. Consider renaming it to 'timezoneOffsetInMs' or adding a comment to clarify.
export function getDayOfWeek(date: Date, timezoneOffset: number): number {

rossgrambo
rossgrambo previously approved these changes Aug 11, 2025
@zhiyuanliang-ms zhiyuanliang-ms merged commit d95cfb6 into main Aug 12, 2025
5 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/recurring-time-window branch August 12, 2025 02:05
zhiyuanliang-ms added a commit that referenced this pull request Aug 20, 2025
* Merge pull request #124 from microsoft/zhiyuanliang/unify-naming-convention

Unify filename naming

* correct file name (#125)

* Recurring time window filter (#73)

* WIP: validation finished

* update filename

* WIP: evaluation done

* add testcases

* fix lint

* update method name

* update

* revert change

* version bump (#126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants