Skip to content

Commit 6563062

Browse files
bmehta001Copilot
andcommitted
Simplify JS model download signatures
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 84508ba commit 6563062

3 files changed

Lines changed: 4 additions & 21 deletions

File tree

sdk/js/src/detail/model.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,6 @@ export class Model implements IModel {
128128
* @param progressCallbackOrSignal - Optional progress callback or AbortSignal.
129129
* @param signal - Optional AbortSignal when a progress callback is provided.
130130
*/
131-
public download(progressCallback?: (progress: number) => void): Promise<void>;
132-
public download(signal: AbortSignal): Promise<void>;
133-
public download(progressCallback: undefined, signal: AbortSignal): Promise<void>;
134-
public download(progressCallback: (progress: number) => void, signal: AbortSignal): Promise<void>;
135131
public download(
136132
progressCallbackOrSignal?: ((progress: number) => void) | AbortSignal,
137133
signal?: AbortSignal

sdk/js/src/detail/modelVariant.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,6 @@ export class ModelVariant implements IModel {
110110
* @param progressCallbackOrSignal - Optional progress callback (0-100) or AbortSignal.
111111
* @param signal - Optional AbortSignal when a progress callback is provided.
112112
*/
113-
public download(progressCallback?: (progress: number) => void): Promise<void>;
114-
public download(signal: AbortSignal): Promise<void>;
115-
public download(progressCallback: undefined, signal: AbortSignal): Promise<void>;
116-
public download(progressCallback: (progress: number) => void, signal: AbortSignal): Promise<void>;
117113
public async download(
118114
progressCallbackOrSignal?: ((progress: number) => void) | AbortSignal,
119115
signal?: AbortSignal

sdk/js/src/imodel.ts

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,11 @@ export interface IModel {
1919

2020
/**
2121
* Download the model to local cache if not already present.
22-
* @param progressCallback - Optional callback for download progress (0-100).
22+
* @param progressCallbackOrSignal - Optional callback for download progress (0-100), or AbortSignal.
23+
* @param signal - Optional AbortSignal when a progress callback is provided.
2324
*/
24-
download(progressCallback?: (progress: number) => void): Promise<void>;
25-
/**
26-
* Download the model to local cache if not already present.
27-
* @param signal - AbortSignal. When aborted, the download will be cancelled at the next progress update.
28-
*/
29-
download(signal: AbortSignal): Promise<void>;
30-
/**
31-
* Download the model to local cache if not already present.
32-
* @param progressCallback - Optional callback for download progress (0-100).
33-
*/
34-
download(progressCallback: undefined, signal: AbortSignal): Promise<void>;
35-
download(progressCallback: (progress: number) => void, signal: AbortSignal): Promise<void>;
25+
download(progressCallbackOrSignal?: ((progress: number) => void) | AbortSignal,
26+
signal?: AbortSignal): Promise<void>;
3627
get path(): string;
3728
load(): Promise<void>;
3829
removeFromCache(): void;

0 commit comments

Comments
 (0)