From a392627d81b11c2905bfd54d268131a0fc859d98 Mon Sep 17 00:00:00 2001 From: Nathan Bu <370788475@qq.com> Date: Fri, 4 Aug 2023 15:38:22 +0800 Subject: [PATCH 1/2] Update HandledErrorLog.java to increase naming --- .../hydralab/common/appcenter/entity/HandledErrorLog.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/common/src/main/java/com/microsoft/hydralab/common/appcenter/entity/HandledErrorLog.java b/common/src/main/java/com/microsoft/hydralab/common/appcenter/entity/HandledErrorLog.java index ff868d832..264ab577f 100644 --- a/common/src/main/java/com/microsoft/hydralab/common/appcenter/entity/HandledErrorLog.java +++ b/common/src/main/java/com/microsoft/hydralab/common/appcenter/entity/HandledErrorLog.java @@ -17,7 +17,7 @@ public class HandledErrorLog implements Log { /** * Log type. */ - public static final String TYPE = "handledError"; + public static final String WARNING_TYPE = "handledError"; /** * Exception associated to the error. @@ -47,6 +47,10 @@ public class HandledErrorLog implements Log { * The optional user identifier. */ private String userId; + /** + * "managedError" -> AppCenter Crash + * "handledError" -> AppCenter Error + */ private String type = "managedError"; /** From 0e229bfb644c2f799af7c8faf3b3693a37738584 Mon Sep 17 00:00:00 2001 From: BryanSharp <8344245+hydraxman@users.noreply.github.com> Date: Sat, 16 Sep 2023 08:04:19 +0800 Subject: [PATCH 2/2] apply the rename and get build pass --- .../hydralab/common/appcenter/AppCenterErrorLogHandler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/src/main/java/com/microsoft/hydralab/common/appcenter/AppCenterErrorLogHandler.java b/common/src/main/java/com/microsoft/hydralab/common/appcenter/AppCenterErrorLogHandler.java index 34c524dd7..1eae0b21f 100644 --- a/common/src/main/java/com/microsoft/hydralab/common/appcenter/AppCenterErrorLogHandler.java +++ b/common/src/main/java/com/microsoft/hydralab/common/appcenter/AppCenterErrorLogHandler.java @@ -122,7 +122,7 @@ public HandledErrorLog createErrorLog(final Thread thread, final Throwable throw /* Uncaught exception or managed exception. */ errorLog.setFatal(fatal); if (!fatal) { - errorLog.setType(HandledErrorLog.TYPE); + errorLog.setType(HandledErrorLog.WARNING_TYPE); } /* Application launch time. */