Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [ci] fix valgrind workflow #6815

Closed
wants to merge 2 commits into from
Closed

WIP: [ci] fix valgrind workflow #6815

wants to merge 2 commits into from

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Feb 7, 2025

The valgrind CI job is failing like this:

/__w/_temp/a09e15f1-9453-4607-9d54-66e1c2404ea4.sh: 6: comment+=https://github.com/microsoft/LightGBM/actions/runs/13159252384: not found

(build link)

This attempts to fix that.

Notes for Reviewers

I first thought that the root cause was that GitHub Actions falls back to sh is bash is not found in PATH: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshell

But wch1/r-debug (the container this runs in) has bash 🤔

@jameslamb
Copy link
Collaborator Author

jameslamb commented Feb 7, 2025

/gha run r-valgrind

Status: failure ❌.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Feb 7, 2025

/gha run r-valgrind

Status: failure ❌.

@jameslamb
Copy link
Collaborator Author

Still seeing an error about += in logs even after removing it here: https://github.com/microsoft/LightGBM/actions/runs/13191763540/job/36825886728#step:6:48

I forgot that for these comment-triggered workflows, the GitHub Actions config is sourced from master. We'll have to merge these changes to test them.

Now that this PR has a failing run of valgrind, it'll be blocked from normal (non-admin) merging. I'll open a new PR.

@jameslamb jameslamb closed this Feb 7, 2025
@jameslamb jameslamb deleted the ci/fix-valgrind branch February 7, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant