Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6815
The valgrind CI job is failing like this:
(build link)
This attempts to fix that.
Notes for Reviewers
As described in #6743,
+=
is a non-POSIX behavior.My guess is that using it in
run:
in GitHub Actions steps is problematic if the shell is not one that recognizes+=
.It should be the case that GitHub Actions is using
bash
in these jobs, which shouldn't be a problem. Per https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshellI'm not sure why (or even if)
bash
is not being found. The container image for the valgrind job definitely does have it.docker run \ --rm \ -it wch1/r-debug \ bash --version # GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
This PR attempts to fix that job in 2 ways:
+=
in Github Actions workflow stepsshell: bash
in those stepsHow to Test This
I think that we'll have to merge this to test it, because the comment-triggered workflows pull configuration from
master
: #6815 (comment)