Fix for issue #5589 #5617
Open
Fix for issue #5589 #5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for all missing properties documented here: https://github.com/microsoftgraph/microsoft-graph-docs-contrib/blob/main/api-reference/beta/resources/intune-mam-iosmanagedappprotection.md Fixes issue microsoft#5589
Added support for missing properties that are documented here: https://github.com/microsoftgraph/microsoft-graph-docs-contrib/blob/main/api-reference/beta/resources/intune-mam-iosmanagedappprotection.md
ykuijs
requested changes
Jan 13, 2025
| @@ -40,6 +44,8 @@ | |||
| * DEPENDENCIES | |||
| * Updated Microsoft.PowerApps.Administration.PowerShell to version 2.0.202. | |||
| * Updated MSCloudLoginAssistant to version 1.1.31. | |||
| * IntuneAppProtectionPolicyiOS | |||
There was a problem hiding this comment.
This one is a duplicate. Please remove
| @@ -14,6 +16,8 @@ | |||
| * DefenderDeviceAuthenticatedScanDefinition | |||
| * Fixed the Data Type export. | |||
| * MISC | |||
| * DEFENDER | |||
There was a problem hiding this comment.
This one is duplicate. Please remove.
| @@ -15,7 +15,113 @@ function Get-TargetResource | |||
| [Parameter()] | |||
| [System.String] | |||
| $Description, | |||
| #my stuff | |||
There was a problem hiding this comment.
Please remove all instances of this line
| [Parameter()] | ||
| [ValidateSet('block', 'wipe', 'warn', 'blockWhenSettingIsSupported')] | ||
| [System.String] | ||
| $appActionIfAccountIsClockedOut, |
There was a problem hiding this comment.
Please use PascalCasing for parameter names, so also starting with a capital letter (this is now using camelCase).
This applies to more parameters than just this one. Please check all new parameters.
| [Parameter()] | ||
| [ValidateSet('block', 'wipe', 'warn', 'blockWhenSettingIsSupported')] | ||
| [System.String] | ||
| $appActionIfAccountIsClockedOut, |
There was a problem hiding this comment.
Is the name of this parameter correct? ClockedOut? Shouldn't this be LockedOut?
| [System.Boolean] | ||
| $ThirdPartyKeyboardsBlocked, | ||
|
|
||
| #my stuff |
| blockDataIngestionIntoOrganizationDocuments = $policy.blockDataIngestionIntoOrganizationDocuments | ||
| customDialerAppProtocol = [string]$policy.customDialerAppProtocol | ||
| deployedAppCount = $policy.deployedAppCount | ||
| #DeploymentSummary = $DeploymentSummaryArray |
There was a problem hiding this comment.
Why is this commented out? Can't this be removed?
| $arrayTemp = @("minimumWarningSdkVersion","maximumRequiredOsVersion","maximumWarningOsVersion","maximumWipeOsVersion") | ||
| Foreach($item in $arrayTemp) | ||
| { | ||
|
|
| @@ -785,6 +1040,17 @@ function Set-TargetResource | |||
| $updateParameters.Remove('Apps') | |||
| $updateParameters.TargetedAppManagementLevels = $updateParameters.TargetedAppManagementLevels -join ',' | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please remove duplicate empty line
| $arrayTemp = @("minimumWarningSdkVersion","maximumRequiredOsVersion","maximumWarningOsVersion","maximumWipeOsVersion") | ||
| Foreach($item in $arrayTemp) | ||
| { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Over time it seem the number of properties have grown, but the module has not been updated.
Have added support for all properties documented here:
https://github.com/microsoftgraph/microsoft-graph-docs-contrib/blob/main/api-reference/beta/resources/intune-mam-iosmanagedappprotection.md
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).