Fixed Scrolling through the history in the color picker editor with a mouse wheel

[Fefedu973]

Summary of the Pull Request

Fixed Scrolling through the history in the color picker editor with a mouse wheel

PR Checklist

• Closes: Color picker - enable scrolling mouse in color picker #31728
• Partially Solve: Address ColorPicker UX issues #32295
• Communication: I've taken the initiative to do it by myself because it was bothering a lot of people (including me lol)
• [] Tests: Idk
• [] Localization: I don't have a clue of what this is
• Dev docs: Nothing to add
• New binaries: No
• Documentation updated: Nothing to add

Detailed Description of the Pull Request / Additional comments

I added a mousewheel event listener on the HistoryColors ListView, then I added two functions in the ColorEditorView.xaml.cs to handle the Event, it checks the number of color in the history and handles the scroll control accordingly

Validation Steps Performed

I tested it, it works

This is my first pull request so idk if i've done it well enough...

[Fefedu973]

@microsoft-github-policy-service agree

[abmprottoy]

Thank you very much for your pull request. Addressing this issue, which has been persistent for several months, is greatly appreciated.

I have run the changes, and they seem to be working as intended.

Desktop.2024.06.29.-.23.27.42.01.mp4

I would like to offer some feedback for consideration:

• The function name might be more descriptive and concise if changed to HistoryColors_OnMouseWheelScroll

• Adding a code comment using the <summary> tag above the function would enhance readability and understanding. Describe your mechanism concisely. Use second person voice. e.g. We added/We then...

• Could you please provide more details regarding the other two commits that involve removing files? Understanding their purpose would be beneficial.

Thank you again for your contribution and effort in resolving this longstanding issue.

[Fefedu973]

Okay I'll do that !
Concerning the two removed files they were automatically generated by visual studio and I forgot to remove them before pushing to my GitHub do I had to remove them afterwards but as you can see in the commit summary there is no deletion from the main source

[Fefedu973]

@abmprottoy it's done !

[abmprottoy]

Thanks for the updates. The build seems to fail on two Tests. Could you please debug the issues? If not, let's wait for someone's expertise on this.

[Fefedu973]

Thanks for the updates. The build seems to fail on two Tests. Could you please debug the issues? If not, let's wait for someone's expertise on this.

It works fine with me I haven't changed anything that can make tests failed in the build logs I saw that it was related to markdown so maybe it failed to fetch the change log during build

[abmprottoy]

@crutkas could you please look into this or assign someone so we can move with this to the next release?

[Fefedu973]

anyone ?

[Fefedu973]

so not in 0.82 i guess...

[abmprottoy]

so not in 0.82 i guess...

Unfortunately, yes. In the meantime, could you please add the "Needs-Review" label to this?
Also please update the PR description appropriately. Test checkbox should be left unticked as there's no Unit Testing added for this function. This PR also doesn't affect localization as there's no user facing string that needs modification for this.

As for the review, we still need one approving review from someone with write access which I lack.

I really hope this gets merged because the issue affects me too.

[Fefedu973]

Ok !

[Fefedu973]

i can't add labels

[Fefedu973]

@htcfreek could you please add the need-review tag pls ?

[crutkas]

so not in 0.82 i guess...

sorry, we had already signed off on 0.82 when this PR came in. We're actively working through our backlog of PRs.

[crutkas]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jaimecbernardo]

/azp run

[azure-pipelines]

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

[jaimecbernardo]

LGTM! Thank you for the contribution!

[Fefedu973]

Nice thanks!

[htcfreek]

@jaimecbernardo
You marked this as good to merge. But sibce that happened Github locked merging. Don't know why.

And I am wondering about the temporary .csproj file. (Why is this part of the PR?)

[jaimecbernardo]

@jaimecbernardo You marked this as good to merge. But sibce that happened Github locked merging. Don't know why.

And I am wondering about the temporary .csproj file. (Why is this part of the PR?)

@htcfreek , I see no csproj in Files changed for this PR. What do you mean?

[jaimecbernardo]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[htcfreek]

@jaimecbernardo You marked this as good to merge. But sibce that happened Github locked merging. Don't know why.

And I am wondering about the temporary .csproj file. (Why is this part of the PR?)

@htcfreek , I see no csproj in Files changed for this PR. What do you mean?

My mistake. Looked at a older commit. Is fixed with on of the last cimmits.

[Fefedu973]

Nice

[Fefedu973]

Idk what happend but on the last version my fix isn't working anymore. Someone broke it lol

[htcfreek]

Idk what happend but on the last version my fix isn't working anymore. Someone broke it lol

@Fefedu973
Can you please open a new issue referencing this fix. Thank you.