Skip to content

Commit 2daa986

Browse files
authored
Restore writeable attribute of geometry interfaces (#1070)
Fixes the first issue raised in #1067.
1 parent ca77744 commit 2daa986

6 files changed

+148
-5
lines changed

baselines/dom.generated.d.ts

+30
Original file line numberDiff line numberDiff line change
@@ -3760,6 +3760,28 @@ declare var DOMImplementation: {
37603760
};
37613761

37623762
interface DOMMatrix extends DOMMatrixReadOnly {
3763+
a: number;
3764+
b: number;
3765+
c: number;
3766+
d: number;
3767+
e: number;
3768+
f: number;
3769+
m11: number;
3770+
m12: number;
3771+
m13: number;
3772+
m14: number;
3773+
m21: number;
3774+
m22: number;
3775+
m23: number;
3776+
m24: number;
3777+
m31: number;
3778+
m32: number;
3779+
m33: number;
3780+
m34: number;
3781+
m41: number;
3782+
m42: number;
3783+
m43: number;
3784+
m44: number;
37633785
invertSelf(): DOMMatrix;
37643786
multiplySelf(other?: DOMMatrixInit): DOMMatrix;
37653787
preMultiplySelf(other?: DOMMatrixInit): DOMMatrix;
@@ -3863,6 +3885,10 @@ declare var DOMParser: {
38633885
};
38643886

38653887
interface DOMPoint extends DOMPointReadOnly {
3888+
w: number;
3889+
x: number;
3890+
y: number;
3891+
z: number;
38663892
}
38673893

38683894
declare var DOMPoint: {
@@ -3906,6 +3932,10 @@ declare var DOMQuad: {
39063932
};
39073933

39083934
interface DOMRect extends DOMRectReadOnly {
3935+
height: number;
3936+
width: number;
3937+
x: number;
3938+
y: number;
39093939
}
39103940

39113941
declare var DOMRect: {

baselines/serviceworker.generated.d.ts

+30
Original file line numberDiff line numberDiff line change
@@ -1010,6 +1010,28 @@ declare var DOMException: {
10101010
};
10111011

10121012
interface DOMMatrix extends DOMMatrixReadOnly {
1013+
a: number;
1014+
b: number;
1015+
c: number;
1016+
d: number;
1017+
e: number;
1018+
f: number;
1019+
m11: number;
1020+
m12: number;
1021+
m13: number;
1022+
m14: number;
1023+
m21: number;
1024+
m22: number;
1025+
m23: number;
1026+
m24: number;
1027+
m31: number;
1028+
m32: number;
1029+
m33: number;
1030+
m34: number;
1031+
m41: number;
1032+
m42: number;
1033+
m43: number;
1034+
m44: number;
10131035
invertSelf(): DOMMatrix;
10141036
multiplySelf(other?: DOMMatrixInit): DOMMatrix;
10151037
preMultiplySelf(other?: DOMMatrixInit): DOMMatrix;
@@ -1085,6 +1107,10 @@ declare var DOMMatrixReadOnly: {
10851107
};
10861108

10871109
interface DOMPoint extends DOMPointReadOnly {
1110+
w: number;
1111+
x: number;
1112+
y: number;
1113+
z: number;
10881114
}
10891115

10901116
declare var DOMPoint: {
@@ -1125,6 +1151,10 @@ declare var DOMQuad: {
11251151
};
11261152

11271153
interface DOMRect extends DOMRectReadOnly {
1154+
height: number;
1155+
width: number;
1156+
x: number;
1157+
y: number;
11281158
}
11291159

11301160
declare var DOMRect: {

baselines/sharedworker.generated.d.ts

+30
Original file line numberDiff line numberDiff line change
@@ -954,6 +954,28 @@ declare var DOMException: {
954954
};
955955

956956
interface DOMMatrix extends DOMMatrixReadOnly {
957+
a: number;
958+
b: number;
959+
c: number;
960+
d: number;
961+
e: number;
962+
f: number;
963+
m11: number;
964+
m12: number;
965+
m13: number;
966+
m14: number;
967+
m21: number;
968+
m22: number;
969+
m23: number;
970+
m24: number;
971+
m31: number;
972+
m32: number;
973+
m33: number;
974+
m34: number;
975+
m41: number;
976+
m42: number;
977+
m43: number;
978+
m44: number;
957979
invertSelf(): DOMMatrix;
958980
multiplySelf(other?: DOMMatrixInit): DOMMatrix;
959981
preMultiplySelf(other?: DOMMatrixInit): DOMMatrix;
@@ -1029,6 +1051,10 @@ declare var DOMMatrixReadOnly: {
10291051
};
10301052

10311053
interface DOMPoint extends DOMPointReadOnly {
1054+
w: number;
1055+
x: number;
1056+
y: number;
1057+
z: number;
10321058
}
10331059

10341060
declare var DOMPoint: {
@@ -1069,6 +1095,10 @@ declare var DOMQuad: {
10691095
};
10701096

10711097
interface DOMRect extends DOMRectReadOnly {
1098+
height: number;
1099+
width: number;
1100+
x: number;
1101+
y: number;
10721102
}
10731103

10741104
declare var DOMRect: {

baselines/webworker.generated.d.ts

+30
Original file line numberDiff line numberDiff line change
@@ -1021,6 +1021,28 @@ declare var DOMException: {
10211021
};
10221022

10231023
interface DOMMatrix extends DOMMatrixReadOnly {
1024+
a: number;
1025+
b: number;
1026+
c: number;
1027+
d: number;
1028+
e: number;
1029+
f: number;
1030+
m11: number;
1031+
m12: number;
1032+
m13: number;
1033+
m14: number;
1034+
m21: number;
1035+
m22: number;
1036+
m23: number;
1037+
m24: number;
1038+
m31: number;
1039+
m32: number;
1040+
m33: number;
1041+
m34: number;
1042+
m41: number;
1043+
m42: number;
1044+
m43: number;
1045+
m44: number;
10241046
invertSelf(): DOMMatrix;
10251047
multiplySelf(other?: DOMMatrixInit): DOMMatrix;
10261048
preMultiplySelf(other?: DOMMatrixInit): DOMMatrix;
@@ -1096,6 +1118,10 @@ declare var DOMMatrixReadOnly: {
10961118
};
10971119

10981120
interface DOMPoint extends DOMPointReadOnly {
1121+
w: number;
1122+
x: number;
1123+
y: number;
1124+
z: number;
10991125
}
11001126

11011127
declare var DOMPoint: {
@@ -1136,6 +1162,10 @@ declare var DOMQuad: {
11361162
};
11371163

11381164
interface DOMRect extends DOMRectReadOnly {
1165+
height: number;
1166+
width: number;
1167+
x: number;
1168+
y: number;
11391169
}
11401170

11411171
declare var DOMRect: {

src/build/bcd/keep-alive.ts

+28-2
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,34 @@ export const forceKeepAlive: Record<string, string[]> = {
9292
],
9393
CloseEvent: ["code", "reason", "wasClean"],
9494
DOMRectList: ["item", "length"],
95-
DOMMatrix: ["fromFloat32Array", "fromFloat64Array", "fromMatrix"],
96-
DOMRect: ["fromRect"],
95+
DOMMatrix: [
96+
"fromFloat32Array",
97+
"fromFloat64Array",
98+
"fromMatrix",
99+
"a",
100+
"b",
101+
"c",
102+
"d",
103+
"e",
104+
"f",
105+
"m11",
106+
"m12",
107+
"m13",
108+
"m14",
109+
"m21",
110+
"m22",
111+
"m23",
112+
"m24",
113+
"m31",
114+
"m32",
115+
"m33",
116+
"m34",
117+
"m41",
118+
"m42",
119+
"m43",
120+
"m44",
121+
],
122+
DOMRect: ["fromRect", "x", "y", "width", "height"],
97123
Document: ["charset", "inputEncoding"],
98124
Element: ["webkitMatchesSelector"],
99125
FileReader: ["onloadstart"],

src/build/widlprocess.ts

-3
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,6 @@ function convertInterfaceCommon(
175175
member.name
176176
);
177177
} else if (member.type === "attribute") {
178-
if ((member.special as string) === "inherit") {
179-
continue; // no need to redeclare
180-
}
181178
const { properties } = result;
182179
const prop = convertAttribute(member, result.exposed);
183180
addComments(prop, commentMap, i.name, member.name);

0 commit comments

Comments
 (0)