Do not generate iterable signatures for static methods (#1839)

saschanaz · web-flow · commit ff8c7517a944 · 2024-11-02T22:52:34.000Z
Co-authored-by: saschanaz &lt;saschanaz@users.noreply.github.com&gt;
diff --git a/baselines/audioworklet.iterable.generated.d.ts b/baselines/audioworklet.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// AudioWorklet Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface MessageEvent<T = any> {
     /** @deprecated */
     initMessageEvent(type: string, bubbles?: boolean, cancelable?: boolean, data?: any, origin?: string, lastEventId?: string, source?: MessageEventSource | null, ports?: Iterable<MessagePort>): void;
diff --git a/baselines/dom.iterable.generated.d.ts b/baselines/dom.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// Window Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface AudioParam {
     /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AudioParam/setValueCurveAtTime) */
     setValueCurveAtTime(values: Iterable<number>, startTime: number, duration: number): AudioParam;
diff --git a/baselines/serviceworker.iterable.generated.d.ts b/baselines/serviceworker.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// ServiceWorker Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface CSSNumericArray {
     [Symbol.iterator](): ArrayIterator<CSSNumericValue>;
     entries(): ArrayIterator<[number, CSSNumericValue]>;
diff --git a/baselines/sharedworker.iterable.generated.d.ts b/baselines/sharedworker.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// SharedWorker Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface CSSNumericArray {
     [Symbol.iterator](): ArrayIterator<CSSNumericValue>;
     entries(): ArrayIterator<[number, CSSNumericValue]>;
diff --git a/baselines/ts5.5/audioworklet.iterable.generated.d.ts b/baselines/ts5.5/audioworklet.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// AudioWorklet Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface MessageEvent<T = any> {
     /** @deprecated */
     initMessageEvent(type: string, bubbles?: boolean, cancelable?: boolean, data?: any, origin?: string, lastEventId?: string, source?: MessageEventSource | null, ports?: Iterable<MessagePort>): void;
diff --git a/baselines/ts5.5/dom.iterable.generated.d.ts b/baselines/ts5.5/dom.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// Window Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface AudioParam {
     /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AudioParam/setValueCurveAtTime) */
     setValueCurveAtTime(values: Iterable<number>, startTime: number, duration: number): AudioParam;
diff --git a/baselines/ts5.5/serviceworker.iterable.generated.d.ts b/baselines/ts5.5/serviceworker.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// ServiceWorker Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface CSSNumericArray {
     [Symbol.iterator](): IterableIterator<CSSNumericValue>;
     entries(): IterableIterator<[number, CSSNumericValue]>;
diff --git a/baselines/ts5.5/sharedworker.iterable.generated.d.ts b/baselines/ts5.5/sharedworker.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// SharedWorker Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface CSSNumericArray {
     [Symbol.iterator](): IterableIterator<CSSNumericValue>;
     entries(): IterableIterator<[number, CSSNumericValue]>;
diff --git a/baselines/ts5.5/webworker.iterable.generated.d.ts b/baselines/ts5.5/webworker.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// Worker Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface CSSNumericArray {
     [Symbol.iterator](): IterableIterator<CSSNumericValue>;
     entries(): IterableIterator<[number, CSSNumericValue]>;
diff --git a/baselines/webworker.iterable.generated.d.ts b/baselines/webworker.iterable.generated.d.ts
@@ -2,11 +2,6 @@
 /// Worker Iterable APIs
 /////////////////////////////
 
-interface AbortSignal {
-    /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/AbortSignal/any_static) */
-    any(signals: Iterable<AbortSignal>): AbortSignal;
-}
-
 interface CSSNumericArray {
     [Symbol.iterator](): ArrayIterator<CSSNumericValue>;
     entries(): ArrayIterator<[number, CSSNumericValue]>;
diff --git a/src/build/emitter.ts b/src/build/emitter.ts
@@ -1736,7 +1736,7 @@ export function emitWebIdl(
     const methodsWithSequence: Browser.Method[] = mapToArray(
       i.methods ? i.methods.method : {},
     )
-      .filter((m) => m.signature && !m.overrideSignatures)
+      .filter((m) => m.signature && !m.overrideSignatures && !m.static)
       .map((m) => ({
         ...m,
         signature: replaceTypedefsInSignatures(

Original file line number	Diff line number	Diff line change
`@@ -1736,7 +1736,7 @@ export function emitWebIdl(`
`1736`	`1736`	`const methodsWithSequence: Browser.Method[] = mapToArray(`
`1737`	`1737`	`i.methods ? i.methods.method : {},`
`1738`	`1738`	`)`
`1739`		`- .filter((m) => m.signature && !m.overrideSignatures)`
	`1739`	`+ .filter((m) => m.signature && !m.overrideSignatures && !m.static)`
`1740`	`1740`	`.map((m) => ({`
`1741`	`1741`	`...m,`
`1742`	`1742`	`signature: replaceTypedefsInSignatures(`