Skip to content

Readonly property permission is missing in Notification global variable #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IlyaVassyutovich opened this issue Jan 17, 2018 · 1 comment · Fixed by #438
Closed

Readonly property permission is missing in Notification global variable #354

IlyaVassyutovich opened this issue Jan 17, 2018 · 1 comment · Fixed by #438

Comments

@IlyaVassyutovich
Copy link

Hello.

Issue title pretty much describes the problem. Readonly property permission with status of permission for web notifications is not emitted in global variable, but present in interface declaration.

Unfortunately, I don't know F# at all... I've tried to fix this using addedTypes.json, but when I add this entry, readonly property permission gets emitted in every single one interface and global variable declaration. And in the docs there is note stating that modification of browser.webidl.xml is forbidden, because it's generated by Microsoft Edge.

{
	"kind": "constant",
	"name": "permission",
	"type": "NotificationPermission"
}

I can make a PR showing my problem, should I?

@mmermerkaya
Copy link

Related issue: microsoft/TypeScript#14701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants