Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParentNode.replaceChildren is excluded, but it's not clear to me why #985

Closed
MaienM opened this issue Mar 1, 2021 · 5 comments
Closed

Comments

@MaienM
Copy link

MaienM commented Mar 1, 2021

It appears that the method replaceChildren on the interface ParentNode has explicitly been excluded. It's not clear to me why this is; as far as I can tell it's stable and present in most browsers. This change was introduced in a seemingly unrelated pull-request, which doesn't provide any hints as to why this was done. Is there a reason for this? Was this an accident?

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Mar 2, 2021

cc @saschanaz

Nicer GUI for the compat data:
https://caniuse.com/mdn-api_element_replacechildren

Support came june, september and october 2020 to the browsers.

@saschanaz
Copy link
Contributor

It wasn't widely available back in 2020. We can now remove the exclusion.

@saschanaz
Copy link
Contributor

As in #1008 (comment), this is fixed.

@github-actions close

@saschanaz
Copy link
Contributor

@github-actions close

@github-actions
Copy link
Contributor

Closing because @saschanaz is one of the code-owners of this repository.

kidonng added a commit to kidonng/refined-github that referenced this issue Sep 30, 2021
Fix missing `ParentNode.replaceChildren` type, see microsoft/TypeScript-DOM-lib-generator#985
krassowski added a commit to krassowski/jupyterlab-limit-output that referenced this issue Mar 24, 2023
see microsoft/TypeScript-DOM-lib-generator#985
which requires an update to a newer version of TypeScript (currently
pinned at 4.1.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants