Fix DOM element check (#2928)

Co-authored-by: Jake Bailey <[email protected]>

Author: HubertY

packages/playground/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript/playground",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "main": "dist/index.js",
   "license": "MIT",
   "private": true,
@@ -16,7 +16,7 @@
   },
   "dependencies": {
     "@typescript/playground-worker": "0.1.0",
-    "@typescript/sandbox": "0.1.1",
+    "@typescript/sandbox": "0.1.2",
     "esbuild": "^0.13.4"
   },
   "devDependencies": {

packages/sandbox/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript/sandbox",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "license": "MIT",
   "author": "TypeScript team",
   "homepage": "https://github.com/microsoft/TypeScript-Website",

packages/sandbox/src/index.ts

@@ -113,10 +113,10 @@ export const createTypeScriptSandbox = (
   monaco: Monaco,
   ts: typeof import("typescript")
 ) => {
-  const config = { ...defaultPlaygroundSettings(), ...partialConfig }
-  if (!("domID" in config) && !("elementToAppend" in config))
+  if (!("domID" in partialConfig) && !("elementToAppend" in partialConfig))
     throw new Error("You did not provide a domID or elementToAppend")
 
+  const config = { ...defaultPlaygroundSettings(), ...partialConfig }
   const defaultText = config.suppressAutomaticallyGettingDefaultText
     ? config.text
     : getInitialCode(config.text, document.location)
@@ -144,7 +144,10 @@ export const createTypeScriptSandbox = (
 
   const language = languageType(config)
   const filePath = createFileUri(config, compilerOptions, monaco)
-  const element = (config as any).elementToAppend ? (config as any).elementToAppend : document.getElementById(config.domID)
+  const element = "elementToAppend" in config ? config.elementToAppend : document.getElementById(config.domID)
+  if (!element)
+    throw new Error("DOM element lookup by domID failed")
+
 
   const model = monaco.editor.createModel(defaultText, language, filePath)
   monaco.editor.defineTheme("sandbox", sandboxTheme)

packages/typescriptlang-org/package.json

@@ -23,8 +23,8 @@
     "@formatjs/intl-relativetimeformat": "^4.5.15",
     "@types/node-fetch": "^2.5.3",
     "@types/react-helmet": "^5.0.15",
-    "@typescript/playground": "0.1.1",
-    "@typescript/sandbox": "0.1.1",
+    "@typescript/playground": "0.1.2",
+    "@typescript/sandbox": "0.1.2",
     "@typescript/twoslash": "3.2.4",
     "gatsby": "^3.8.1",
     "gatsby-link": "3.10.0",

yarn.lock

@@ -6054,13 +6054,13 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@typescript/[email protected].1, @typescript/playground@workspace:packages/playground":
+"@typescript/[email protected].2, @typescript/playground@workspace:packages/playground":
   version: 0.0.0-use.local
   resolution: "@typescript/playground@workspace:packages/playground"
   dependencies:
     "@types/jest": ^25.1.3
     "@typescript/playground-worker": 0.1.0
-    "@typescript/sandbox": 0.1.1
+    "@typescript/sandbox": 0.1.2
     esbuild: ^0.13.4
     jest: ^29.5.0
     monaco-editor: ^0.32.1
@@ -6069,7 +6069,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@typescript/[email protected].1, @typescript/sandbox@workspace:packages/sandbox":
+"@typescript/[email protected].2, @typescript/sandbox@workspace:packages/sandbox":
   version: 0.0.0-use.local
   resolution: "@typescript/sandbox@workspace:packages/sandbox"
   dependencies:
@@ -28857,8 +28857,8 @@ resolve@^2.0.0-next.3:
     "@types/react": ^16.9.20
     "@types/react-dom": ^16.9.5
     "@types/react-helmet": ^5.0.15
-    "@typescript/playground": 0.1.1
-    "@typescript/sandbox": 0.1.1
+    "@typescript/playground": 0.1.2
+    "@typescript/sandbox": 0.1.2
     "@typescript/twoslash": 3.2.4
     concurrently: ^5.1.0
     gatsby: ^3.8.1