Add error message for set accessor vsibility issues (#33683)

Author: weswigham

src/compiler/diagnosticMessages.json

@@ -3072,7 +3072,6 @@
         "category": "Error",
         "code": 4094
     },
-
     "Public static method '{0}' of exported class has or is using name '{1}' from external module {2} but cannot be named.": {
         "category": "Error",
         "code": 4095
@@ -3117,6 +3116,18 @@
         "category": "Error",
         "code": 4105
     },
+    "Parameter '{0}' of accessor has or is using private name '{1}'.": {
+        "category": "Error",
+        "code": 4106
+    },
+    "Parameter '{0}' of accessor has or is using name '{1}' from private module '{2}'.": {
+        "category": "Error",
+        "code": 4107
+    },
+    "Parameter '{0}' of accessor has or is using name '{1}' from external module '{2}' but cannot be named.": {
+        "category": "Error",
+        "code": 4108
+    },
 
     "The current host does not support the '{0}' option.": {
         "category": "Error",

src/compiler/transformers/declarations/diagnostics.ts

@@ -373,6 +373,13 @@ namespace ts {
                             Diagnostics.Parameter_0_of_exported_function_has_or_is_using_name_1_from_external_module_2_but_cannot_be_named :
                             Diagnostics.Parameter_0_of_exported_function_has_or_is_using_name_1_from_private_module_2 :
                         Diagnostics.Parameter_0_of_exported_function_has_or_is_using_private_name_1;
+                case SyntaxKind.SetAccessor:
+                case SyntaxKind.GetAccessor:
+                    return symbolAccessibilityResult.errorModuleName ?
+                        symbolAccessibilityResult.accessibility === SymbolAccessibility.CannotBeNamed ?
+                            Diagnostics.Parameter_0_of_accessor_has_or_is_using_name_1_from_external_module_2_but_cannot_be_named :
+                            Diagnostics.Parameter_0_of_accessor_has_or_is_using_name_1_from_private_module_2 :
+                        Diagnostics.Parameter_0_of_accessor_has_or_is_using_private_name_1;
 
                 default:
                     return Debug.fail(`Unknown parent for parameter: ${(ts as any).SyntaxKind[node.parent.kind]}`);

tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.errors.txt

@@ -0,0 +1,12 @@
+tests/cases/compiler/accessorDeclarationEmitVisibilityErrors.ts(2,18): error TS2304: Cannot find name 'DoesNotExist'.
+tests/cases/compiler/accessorDeclarationEmitVisibilityErrors.ts(2,18): error TS4106: Parameter 'arg' of accessor has or is using private name 'DoesNotExist'.
+
+
+==== tests/cases/compiler/accessorDeclarationEmitVisibilityErrors.ts (2 errors) ====
+    export class Q {
+        set bet(arg: DoesNotExist) {}
+                     ~~~~~~~~~~~~
+!!! error TS2304: Cannot find name 'DoesNotExist'.
+                     ~~~~~~~~~~~~
+!!! error TS4106: Parameter 'arg' of accessor has or is using private name 'DoesNotExist'.
+    }

tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.js

@@ -0,0 +1,9 @@
+//// [accessorDeclarationEmitVisibilityErrors.ts]
+export class Q {
+    set bet(arg: DoesNotExist) {}
+}
+
+//// [accessorDeclarationEmitVisibilityErrors.js]
+export class Q {
+    set bet(arg) { }
+}

tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.symbols

@@ -0,0 +1,8 @@
+=== tests/cases/compiler/accessorDeclarationEmitVisibilityErrors.ts ===
+export class Q {
+>Q : Symbol(Q, Decl(accessorDeclarationEmitVisibilityErrors.ts, 0, 0))
+
+    set bet(arg: DoesNotExist) {}
+>bet : Symbol(Q.bet, Decl(accessorDeclarationEmitVisibilityErrors.ts, 0, 16))
+>arg : Symbol(arg, Decl(accessorDeclarationEmitVisibilityErrors.ts, 1, 12))
+}

tests/baselines/reference/accessorDeclarationEmitVisibilityErrors.types

@@ -0,0 +1,8 @@
+=== tests/cases/compiler/accessorDeclarationEmitVisibilityErrors.ts ===
+export class Q {
+>Q : Q
+
+    set bet(arg: DoesNotExist) {}
+>bet : any
+>arg : any
+}

tests/cases/compiler/accessorDeclarationEmitVisibilityErrors.ts

@@ -0,0 +1,7 @@
+// @target: es6
+// @strict: true
+// @declaration: true
+
+export class Q {
+    set bet(arg: DoesNotExist) {}
+}