Consolidate Docker verification into a shared composite action

Replace ad-hoc `docker info` calls in the CI workflows with a single
shared composite action at `.github/actions/verify-docker`. The action
runs `docker info` as the gating check and always emits
`docker version` and `docker buildx version` diagnostics, so the
build log is useful even when the daemon is broken. `docker info`'s
exit code is re-raised at the end so the step still fails on a missing
or unreachable daemon.

The action is a no-op on non-Linux runners, so callers in cross-OS
matrices (run-tests.yml, reproduce-flaky-tests.yml) can drop their
`if: runner.os == 'Linux'` guards.

Migrate all five callers (build-cli-e2e-image, deployment-tests,
reproduce-flaky-tests, run-tests, tests-daily-smoke) and add
docs/ci/verify-docker.md.

Co-authored-by: Copilot <[email protected]>

Author: radical

.github/actions/verify-docker/action.yml

@@ -0,0 +1,20 @@
+name: 'Verify Docker'
+description: 'Verify that the runner Docker daemon is available and emit Docker/buildx version diagnostics. No-op on non-Linux runners.'
+runs:
+  using: "composite"
+  steps:
+    - name: Verify Docker daemon and emit diagnostics
+      # Aspire CI only relies on Docker on Linux runners; the macOS and Windows
+      # GitHub-hosted runners don't have a working Docker daemon. Skip there so
+      # callers don't need to repeat `if: runner.os == 'Linux'` at every call site.
+      if: runner.os == 'Linux'
+      shell: bash
+      run: |
+        # Run docker info first as the gating check, but never let it short-circuit
+        # the diagnostics that follow — those are most useful when the daemon is
+        # broken. Re-raise its exit code at the end so the step still fails.
+        rc=0
+        docker info || rc=$?
+        docker version || echo "::warning::docker version failed with exit code $?"
+        docker buildx version || echo "::warning::docker buildx version failed with exit code $?"
+        exit $rc

.github/workflows/build-cli-e2e-image.yml

@@ -38,7 +38,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
 
       - name: Verify Docker is running
-        run: docker info
+        uses: ./.github/actions/verify-docker
 
       - name: Export GitHub Actions cache runtime
         uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1

.github/workflows/deployment-tests.yml

@@ -245,11 +245,7 @@ jobs:
           echo "✅ Azure authentication successful"
 
       - name: Verify Docker is running
-        run: |
-          echo "Verifying Docker daemon..."
-          docker version
-          docker info | head -20
-          echo "✅ Docker is available"
+        uses: ./.github/actions/verify-docker
 
       - name: Run deployment test (${{ matrix.shortname }})
         id: run_tests

.github/workflows/reproduce-flaky-tests.yml

@@ -177,9 +177,8 @@ jobs:
         env:
           WSL_INTEROP: ""
 
-      - name: Verify Docker is running (Linux)
-        if: runner.os == 'Linux'
-        run: docker info
+      - name: Verify Docker is running
+        uses: ./.github/actions/verify-docker
 
       - name: Download prebuilt CLI E2E Docker image
         if: ${{ needs.setup.outputs.is_cli_e2e == 'true' && runner.os == 'Linux' }}

.github/workflows/run-tests.yml

@@ -114,9 +114,7 @@ jobs:
           WSL_INTEROP: ""
 
       - name: Verify Docker is running
-        # nested docker containers not supported on windows
-        if: runner.os == 'Linux'
-        run: docker info
+        uses: ./.github/actions/verify-docker
 
       - name: Download prebuilt CLI E2E Docker image
         if: ${{ fromJson(inputs.properties).requiresCliArchive == true && runner.os == 'Linux' }}

.github/workflows/tests-daily-smoke.yml

@@ -53,7 +53,7 @@ jobs:
         run: ./restore.sh
 
       - name: Verify Docker is running
-        run: docker info
+        uses: ./.github/actions/verify-docker
 
       - name: Download prebuilt CLI E2E Docker image
         uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1

docs/ci/verify-docker.md

@@ -0,0 +1,7 @@
+# Verify Docker action
+
+Workflows that need Docker should use `.github/actions/verify-docker` instead of running `docker info` directly. The action checks that the Docker daemon is reachable with `docker info` and always emits `docker version` and `docker buildx version` so logs are useful when the daemon is broken.
+
+The action is a no-op on non-Linux runners, so callers can use it unconditionally even from cross-OS jobs — there's no need to gate the step with `if: runner.os == 'Linux'`.
+
+Extend this action when CI needs a stronger Docker runner contract.