More logging

Author: JamesNK

src/Aspire.Cli/Projects/ProcessGuestLauncher.cs

@@ -123,6 +123,7 @@ public ProcessGuestLauncher(string language, ILogger logger, FileLoggerProvider?
 
         AddEvent(activity, ProfilingTelemetry.Events.GuestProcessStart);
         process.Start();
+        _logger.LogDebug("{Language} guest process {ProcessId} started: {Command}", _language, process.Id, resolvedCommandPath);
         activity?.SetTag(TelemetryConstants.Tags.ProcessPid, process.Id);
         AddEvent(activity, ProfilingTelemetry.Events.GuestProcessStarted, TelemetryConstants.Tags.ProcessPid, process.Id);
         if (afterLaunchAsync is not null)
@@ -135,7 +136,12 @@ public ProcessGuestLauncher(string language, ILogger logger, FileLoggerProvider?
 
         try
         {
-            await process.WaitForExitAsync(cancellationToken);
+            var waitForExitTask = process.WaitForExitAsync(cancellationToken);
+
+            using var _ = cancellationToken.Register(() =>
+                _logger.LogInformation("Cancellation requested while waiting for {Language} guest process {ProcessId} to exit", _language, process.Id));
+
+            await waitForExitTask.ConfigureAwait(false);
         }
         catch (OperationCanceledException)
         {
@@ -152,6 +158,7 @@ public ProcessGuestLauncher(string language, ILogger logger, FileLoggerProvider?
             // the redirected output streams have time to drain.
             if (!process.HasExited)
             {
+                _logger.LogInformation("Killing {Language} guest process tree {ProcessId}", _language, process.Id);
                 try
                 {
                     process.Kill(entireProcessTree: true);
@@ -161,10 +168,17 @@ public ProcessGuestLauncher(string language, ILogger logger, FileLoggerProvider?
                     _logger.LogDebug(killEx, "Failed to kill guest process {ProcessId} after cancellation", process.Id);
                 }
             }
+            else
+            {
+                _logger.LogDebug("{Language} guest process {ProcessId} already exited before kill", _language, process.Id);
+            }
 
+            _logger.LogDebug("Waiting for {Language} guest process {ProcessId} to exit after kill", _language, process.Id);
             await process.WaitForExitAsync(CancellationToken.None).ConfigureAwait(false);
         }
 
+        _logger.LogDebug("{Language} guest process {ProcessId} exited with code {ExitCode}", _language, process.Id, process.ExitCode);
+
         activity?.SetTag(TelemetryConstants.Tags.ProcessExitCode, process.ExitCode);
         AddEvent(activity, ProfilingTelemetry.Events.GuestProcessExited, TelemetryConstants.Tags.ProcessExitCode, process.ExitCode);